Make ConvertJavaToUTF functions more robusts.

Make ConvertJavaToUTF functions more robusts.

The ConvertJavaToUTF functions can have undefined behavior when called with
null strings.  This CL makes it easier to catch such problems.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156965

[bulach, 2012-09-13 10:02:55]

lgtm, but one suggestion:

https://codereview.chromium.org/10916281/diff/1/base/android/jni_string.cc
File base/android/jni_string.cc (right):

https://codereview.chromium.org/10916281/diff/1/base/android/jni_string.cc#ne...
base/android/jni_string.cc:52: NOTREACHED() << " ConvertJavaStringToUTF16 called
with null string.";
hmm, I'm not sure about the NOTREACHED here..

I think it'd be clearer either with an imperative CHECK:
CHECK(str) << "ConvertJavaStringToUTF16 called with null string.";

or a just a LOG:

if (!str) {
  LOG(WARNING) << " ConvertJavaStringToUTF16 called with null string.";
  return string16();
}

what do you think?

[commit-bot: I haz the power, 2012-09-14 22:45:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/10916281/4002

[commit-bot: I haz the power, 2012-09-15 02:08:58]

Change committed as 156965