Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10916276: sync: add Google API Key to all ClientToServerMessages (Closed)

Created:
8 years, 3 months ago by tim (not reviewing)
Modified:
8 years, 3 months ago
Reviewers:
akalin, Jói
CC:
chromium-reviews, Raghu Simha, ncarter (slow), haitaol1, akalin
Visibility:
Public.

Description

sync: add Google API Key to all ClientToServerMessages. Also move setting of "must have" sync fields to PostClientToServerMessage (from DownloadUpdatesCommand & BuildCommitCommand). Needed for M23 branch. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157081

Patch Set 1 : init #

Patch Set 2 : rebase #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M sync/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sync/engine/build_commit_command.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M sync/engine/commit.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/download_updates_command.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M sync/engine/syncer_proto_util.h View 1 1 chunk +1 line, -1 line 1 comment Download
M sync/engine/syncer_proto_util.cc View 1 2 2 chunks +14 lines, -10 lines 0 comments Download
M sync/protocol/sync.proto View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sync/sync.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M sync/test/engine/mock_connection_manager.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tim (not reviewing)
8 years, 3 months ago (2012-09-13 00:52:42 UTC) #1
tim (not reviewing)
+joi FYI
8 years, 3 months ago (2012-09-13 00:53:06 UTC) #2
Jói
Groovy, thanks Tim. On Thu, Sep 13, 2012 at 12:53 AM, <tim@chromium.org> wrote: > +joi ...
8 years, 3 months ago (2012-09-13 10:12:43 UTC) #3
tim (not reviewing)
Fred: ping :) (Has to make the branch cut tomorrow). On 2012/09/13 10:12:43, Jói wrote: ...
8 years, 3 months ago (2012-09-17 03:05:38 UTC) #4
akalin
lgtm http://codereview.chromium.org/10916276/diff/14001/sync/engine/syncer_proto_util.h File sync/engine/syncer_proto_util.h (right): http://codereview.chromium.org/10916276/diff/14001/sync/engine/syncer_proto_util.h#newcode42 sync/engine/syncer_proto_util.h:42: // Posts the given message and fills the ...
8 years, 3 months ago (2012-09-17 03:30:23 UTC) #5
akalin
i'll check commit box now since it has to make the branch. feel free to ...
8 years, 3 months ago (2012-09-17 03:31:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/10916276/14001
8 years, 3 months ago (2012-09-17 03:31:14 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-17 05:40:07 UTC) #8
Change committed as 157081

Powered by Google App Engine
This is Rietveld 408576698