Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: net/spdy/spdy_session.cc

Issue 10916275: * Change logic of SpdySession::VerifyDomainAuthentication to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/spdy/spdy_session_spdy3_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index 7610c9c7f740ab5389a9a519f670711f889e954c..f9238ecbe61ca19e429ae7f8464a3773757e0851 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -435,7 +435,10 @@ bool SpdySession::VerifyDomainAuthentication(const std::string& domain) {
return true; // This is not a secure session, so all domains are okay.
return !ssl_info.client_cert_sent &&
- (g_enable_credential_frames || !ssl_info.channel_id_sent) &&
+ (g_enable_credential_frames || !ssl_info.channel_id_sent ||
+ ServerBoundCertService::GetDomainForHost(domain) ==
+ ServerBoundCertService::GetDomainForHost(
+ host_port_proxy_pair_.first.host())) &&
wtc 2012/09/19 22:42:35 It would be useful to add a comment to explain thi
ssl_info.cert->VerifyNameMatch(domain);
}
« no previous file with comments | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/spdy/spdy_session_spdy3_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698