Issue 10916275: * Change logic of SpdySession::VerifyDomainAuthentication to

Issue 10916275: * Change logic of SpdySession::VerifyDomainAuthentication to (Closed)

Created:
8 years, 3 months ago by Ryan Hamilton

Modified:
8 years, 3 months ago

Reviewers:
wtc, Ryan Sleevi, mattm

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

* Change logic of SpdySession::VerifyDomainAuthentication to permit connection pooling of hosts with the same etld when TLS channel ID is used. * Add tests for SpdySession::VerifyDomainAuthentication * Add a new certificate for testing SpdySession::VerifyDomainAuthentication BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156461

Patch Set 1 #

Patch Set 2 : Add new pem to readme #

Total comments: 2

Patch Set 3 : FIx comment #

Patch Set 4 : fix test #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+234 lines, -2 lines)			Patch
M	net/data/ssl/certificates/README	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A	net/data/ssl/certificates/spdy_pooling.pem	View		1 chunk	+53 lines, -0 lines	0 comments	Download
M	net/data/ssl/scripts/ee.cnf	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket_pool_unittest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_session.cc	View		1 chunk	+4 lines, -1 line	1 comment	Download
M	net/spdy/spdy_session_spdy3_unittest.cc	View		2 chunks	+162 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

rsleevi: can you look at the changes to net/data/ssl mattam: can you verify the spdy ...

8 years, 3 months ago (2012-09-12 22:07:20 UTC) #1

Ryan Sleevi

net/data LGTM, mod nit. https://chromiumcodereview.appspot.com/10916275/diff/2001/net/data/ssl/scripts/ee.cnf File net/data/ssl/scripts/ee.cnf (right): https://chromiumcodereview.appspot.com/10916275/diff/2001/net/data/ssl/scripts/ee.cnf#newcode37 net/data/ssl/scripts/ee.cnf:37: DNS.3 = mail.example.com nit: Move ...

8 years, 3 months ago (2012-09-12 22:24:30 UTC) #2

Ryan Hamilton

https://chromiumcodereview.appspot.com/10916275/diff/2001/net/data/ssl/scripts/ee.cnf File net/data/ssl/scripts/ee.cnf (right): https://chromiumcodereview.appspot.com/10916275/diff/2001/net/data/ssl/scripts/ee.cnf#newcode37 net/data/ssl/scripts/ee.cnf:37: DNS.3 = mail.example.com On 2012/09/12 22:24:31, Ryan Sleevi wrote: ...

8 years, 3 months ago (2012-09-12 22:30:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10916275/8002

8 years, 3 months ago (2012-09-12 23:12:54 UTC) #5

wtc

8 years, 3 months ago (2012-09-19 22:42:35 UTC) #7

https://chromiumcodereview.appspot.com/10916275/diff/8002/net/spdy/spdy_sessi...
File net/spdy/spdy_session.cc (right):

https://chromiumcodereview.appspot.com/10916275/diff/8002/net/spdy/spdy_sessi...
net/spdy/spdy_session.cc:441: host_port_proxy_pair_.first.host())) &&

It would be useful to add a comment to explain this new test.

If the new host name is in the same subdomain, then it shares
the same channel ID and therefore we don't need to send a
CREDENTIAL frame for the new host name.

Expand Messages | Collapse Messages