Issue 10916274: Ensure that windows belonging to a different profile show up when the corresponding user avatar is …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10916274: Ensure that windows belonging to a different profile show up when the corresponding user avatar is … (Closed)

Created:
8 years, 3 months ago by ananta

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Ensure that windows belonging to a different profile show up when the corresponding user avatar is selected. BUG=141712 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156434

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	chrome/browser/ui/views/frame/browser_frame_win.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/frame/browser_frame_win.cc	View		1 chunk	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

https://chromiumcodereview.appspot.com/10916274/diff/1/chrome/browser/ui/views/frame/browser_frame_win.cc File chrome/browser/ui/views/frame/browser_frame_win.cc (right): https://chromiumcodereview.appspot.com/10916274/diff/1/chrome/browser/ui/views/frame/browser_frame_win.cc#newcode353 chrome/browser/ui/views/frame/browser_frame_win.cc:353: // In Windows 8 metro mode we have only ...

8 years, 3 months ago (2012-09-12 23:19:01 UTC) #2

LGTM - add more comments though.

Expand Messages | Collapse Messages