Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 10916264: Revert 156233 - Make apks be built in a consistent way (Closed)

Created:
8 years, 3 months ago by Peter Beverloo
Modified:
8 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, olilan
Visibility:
Public.

Description

Revert 156233 - Make apks be built in a consistent way This broke non-incremental Android builds. Simplify apk targets by doing most of the work in build/java_apk.gypi (like jars are done with build/java.gypi). The apk targets still use their own ant build files, but everything else is more consistent between them. BUG= Review URL: https://chromiumcodereview.appspot.com/10914130 TBR=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -93 lines) Patch
D build/java_apk.gypi View 1 chunk +0 lines, -75 lines 0 comments Download
M content/content_shell.gypi View 2 chunks +38 lines, -9 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +29 lines, -7 lines 0 comments Download
M content/shell/android/java/content_shell_apk.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/javatests/content_shell_test_apk.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Beverloo
8 years, 3 months ago (2012-09-12 16:06:31 UTC) #1
Peter Beverloo
8 years, 3 months ago (2012-09-12 16:10:12 UTC) #2
Hi Chris,

Sorry for rolling this out as you weren't really able to know that it was going
to break, because the try-bots turned green and the main and FYI builders
remained green as well.

For clobber builds (i.e. non-incremental), this did seem to cause a compile
error, as can be seen in this log file:

http://build.chromium.org/p/tryserver.chromium/builders/android/builds/35987/...

Isaac may be able to give you an estimate on when our clobber builder will
appear on the main waterfall, which should make this more obvious. I'm not sure
if try-jobs will also change to be clobber builders.

Powered by Google App Engine
This is Rietveld 408576698