Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 10916263: [Chromoting] Refactoring DesktopEnvironment and moving screen/audio recorders to ClientSession. (Closed)

Created:
8 years, 3 months ago by alexeypa (please no reviews)
Modified:
8 years, 3 months ago
Reviewers:
simonmorris
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Refactoring DesktopEnvironment and moving screen/audio recorders to ClientSession. This CL changes the way screen/audio recorders and event executors are managed. New DesktopEnvironmentFactory class is now used by ChromotingHost's owner to specify the kind of desktop environment (or virtual terminal) to be used by the host. Screen/audio recorders and event executors now owned by the ClientSession instance, so there is a separate set of recorders and stubs exists for each authenticated client session. Clients sessions can now be torn dowsn in parallel with the host shuttting down. This is the 4th attempt to land this change. This version includes: - |ClientSession| objects are torn down asynchronously now. - |ClientSession| objects are ref-counted to facilitate the asynchronous shutdown. They still have to be used and destroyed on the network thread. - |ChromotingHost| now waits until all connections are torn down before deleting the session manager. - The unit tests were fixed to run message loops until all asynchronous object have been destroyed. - |ClientSessionTest.ClampMouseEvents| makes sure that the expectations are destroyed when leaving TEST_F scope so that ASAN is not getting confused. BUG=134694 TEST=remoting_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156398

Patch Set 1 #

Patch Set 2 : Don't use base::Unretained on ref-counted ClientSession. #

Patch Set 3 : Make sure that expectations are deleted when exiting TEST_F scope so that ASAN does not get confuse… #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+782 lines, -722 lines) Patch
M remoting/host/chromoting_host.h View 7 chunks +15 lines, -35 lines 0 comments Download
M remoting/host/chromoting_host.cc View 9 chunks +37 lines, -141 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 1 9 chunks +75 lines, -43 lines 0 comments Download
M remoting/host/client_session.h View 7 chunks +70 lines, -17 lines 0 comments Download
M remoting/host/client_session.cc View 8 chunks +137 lines, -11 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 2 10 chunks +105 lines, -30 lines 0 comments Download
M remoting/host/desktop_environment.h View 2 chunks +11 lines, -32 lines 0 comments Download
M remoting/host/desktop_environment.cc View 1 chunk +10 lines, -78 lines 0 comments Download
A remoting/host/desktop_environment_factory.h View 1 chunk +34 lines, -0 lines 0 comments Download
A remoting/host/desktop_environment_factory.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M remoting/host/event_executor.h View 1 chunk +3 lines, -3 lines 0 comments Download
A remoting/host/event_executor_fake.h View 1 chunk +36 lines, -0 lines 0 comments Download
A remoting/host/event_executor_fake.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M remoting/host/event_executor_linux.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/event_executor_mac.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M remoting/host/event_executor_win.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M remoting/host/host_mock_objects.h View 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M remoting/host/plugin/host_script_object.h View 1 2 3 3 chunks +6 lines, -8 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 2 3 6 chunks +8 lines, -34 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M remoting/host/screen_recorder_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
D remoting/host/session_event_executor_win.h View 1 chunk +0 lines, -69 lines 0 comments Download
D remoting/host/session_event_executor_win.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M remoting/host/simple_host_process.cc View 4 chunks +36 lines, -13 lines 0 comments Download
A remoting/host/win/session_desktop_environment_factory.h View 1 chunk +26 lines, -0 lines 0 comments Download
A remoting/host/win/session_desktop_environment_factory.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A + remoting/host/win/session_event_executor.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + remoting/host/win/session_event_executor.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.cc View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alexeypa (please no reviews)
Relanding r156297. r156297 didn't go though the try bots because the bots weren't able to ...
8 years, 3 months ago (2012-09-12 16:11:53 UTC) #1
simonmorris
lgtm
8 years, 3 months ago (2012-09-12 18:02:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10916263/7002
8 years, 3 months ago (2012-09-12 18:29:10 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-12 22:18:03 UTC) #4
Failed to apply patch for remoting/host/plugin/host_script_object.cc:
While running patch -p1 --forward --force;
patching file remoting/host/plugin/host_script_object.cc
Hunk #2 succeeded at 93 with fuzz 1.
Hunk #3 succeeded at 518 (offset 6 lines).
Hunk #4 succeeded at 550 (offset 6 lines).
Hunk #5 succeeded at 583 (offset 6 lines).
Hunk #6 FAILED at 870.
Hunk #7 FAILED at 900.
2 out of 7 hunks FAILED -- saving rejects to file
remoting/host/plugin/host_script_object.cc.rej

Powered by Google App Engine
This is Rietveld 408576698