tools/chrome_remote_control/chrome_remote_control/browser_unittest.py - Issue 10916227: More polish in prep for CrOS support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/browser_unittest.py

Issue 10916227: More polish in prep for CrOS support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_remote_control/chrome_remote_control/browser_options_unittest.py ('k') | tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_remote_control/chrome_remote_control/browser_unittest.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/browser_unittest.py b/tools/chrome_remote_control/chrome_remote_control/browser_unittest.py

index 1666196a62b2a77e6387d8c240221f52d429c176..1cd6b6667cdd255aa880cefb69d7ec0b66ac8861 100644

--- a/tools/chrome_remote_control/chrome_remote_control/browser_unittest.py

+++ b/tools/chrome_remote_control/chrome_remote_control/browser_unittest.py

@@ -9,7 +9,6 @@ import browser_options

class BrowserTest(unittest.TestCase):

def testBasic(self):

options = browser_options.options_for_unittests

- options.browser_to_use = browser_finder.ALL_BROWSER_TYPES

browser_to_create = browser_finder.FindBrowser(options)

if not browser_to_create:

raise Exception('No browser found, cannot continue test.')

@@ -24,7 +23,6 @@ class BrowserTest(unittest.TestCase):

# create a chrome.Interval namespace. This tests whether the command line is

# being set.

options = browser_options.options_for_unittests

- options.browser_to_use = browser_finder.ALL_BROWSER_TYPES

testJS = ("window.chrome.gpuBenchmarking !== undefined ||" +

"chrome.Interval !== undefined")