Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: tools/chrome_remote_control/chrome_remote_control/browser_options.py

Issue 10916227: More polish in prep for CrOS support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for landing Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_remote_control/chrome_remote_control/browser_options.py
diff --git a/tools/chrome_remote_control/chrome_remote_control/browser_options.py b/tools/chrome_remote_control/chrome_remote_control/browser_options.py
index 3e7c32bde24c16cfd3feb8ac4d0c8f0f7d8f61f6..e2fb6fd6d0c8805bd38d927bfb895dddf13c4b71 100644
--- a/tools/chrome_remote_control/chrome_remote_control/browser_options.py
+++ b/tools/chrome_remote_control/chrome_remote_control/browser_options.py
@@ -4,6 +4,7 @@
import optparse
import sys
import shlex
+import logging
import browser_finder
@@ -62,6 +63,13 @@ class BrowserOptions(optparse.Values):
help="When possible, will display the stdout of the process")
parser.add_option_group(group)
+ # Debugging options
+ group = optparse.OptionGroup(parser, "When things go wrong")
+ group.add_option(
+ '-v', '--verbose', action='count', dest="verbosity",
+ help='Increase verbosity level (repeat as needed)')
+ parser.add_option_group(group)
+
real_parse = parser.parse_args
def ParseArgs(args=None):
defaults = parser.get_default_values()
@@ -70,6 +78,14 @@ class BrowserOptions(optparse.Values):
continue
self.__dict__[k] = v
ret = real_parse(args, self)
+
+ if self.verbosity >= 2:
+ logging.basicConfig(level=logging.DEBUG)
+ elif self.verbosity:
+ logging.basicConfig(level=logging.INFO)
+ else:
+ logging.basicConfig(level=logging.WARNING)
+
if self.browser_executable and not self.browser_type:
self.browser_type = 'exact'
if not self.browser_executable and not self.browser_type:

Powered by Google App Engine
This is Rietveld 408576698