Conservative update button/label/textfield content

Conservative update button/label/textfield content

Saves a repaint when no change actually occurs.

BUG=chrome-os-partner:13141
TEST=build, run on lumpy, lucas

Change-Id: I6ccb75141b7639571e24b2fbf7e3986d85e98cbc


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156200

[sheu, 2012-09-11 20:42:09]

Round 1.

[Daniel Erat, 2012-09-11 20:53:37]

https://chromiumcodereview.appspot.com/10916222/diff/1/ui/views/controls/butt...
File ui/views/controls/button/text_button.cc (right):

https://chromiumcodereview.appspot.com/10916222/diff/1/ui/views/controls/butt...
ui/views/controls/button/text_button.cc:294: if (text != text_) {
nit: just:

  if (text == text_)
    return;

and then unindent the rest?

https://chromiumcodereview.appspot.com/10916222/diff/1/ui/views/controls/labe...
File ui/views/controls/label.cc (right):

https://chromiumcodereview.appspot.com/10916222/diff/1/ui/views/controls/labe...
ui/views/controls/label.cc:57: if (text != text_) {
nit: same here

https://chromiumcodereview.appspot.com/10916222/diff/1/ui/views/controls/text...
File ui/views/controls/textfield/textfield.cc (right):

https://chromiumcodereview.appspot.com/10916222/diff/1/ui/views/controls/text...
ui/views/controls/textfield/textfield.cc:152: if (text != text_) {
and here

[sheu, 2012-09-11 21:29:27]

up!

[Daniel Erat, 2012-09-11 21:32:43]

lgtm

[commit-bot: I haz the power, 2012-09-11 22:02:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheu@chromium.org/10916222/6001

[commit-bot: I haz the power, 2012-09-11 22:02:54]

Presubmit check for 10916222-6001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ui/views

Presubmit checks took 1.4s to calculate.

[Ben Goodger (Google), 2012-09-11 22:26:55]

lgtm

[commit-bot: I haz the power, 2012-09-11 22:51:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheu@chromium.org/10916222/6001

[commit-bot: I haz the power, 2012-09-12 01:31:34]

Change committed as 156200