Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ConvertMethodToGetterRefactoring.java

Issue 10916211: Issue 4752. When convert to getter, remove also () (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use setter in *Info Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ConvertMethodToGetterRefactoring.java
diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ConvertMethodToGetterRefactoring.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ConvertMethodToGetterRefactoring.java
index 79496904885d75d82d0bf8fc386380b1e70891cd..692e8c07ee7a7815108ce0f9d28d1a14e446e252 100644
--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ConvertMethodToGetterRefactoring.java
+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ConvertMethodToGetterRefactoring.java
@@ -43,6 +43,7 @@ import org.eclipse.ltk.core.refactoring.Refactoring;
import org.eclipse.ltk.core.refactoring.RefactoringStatus;
import org.eclipse.ltk.core.refactoring.TextChange;
import org.eclipse.text.edits.ReplaceEdit;
+import org.eclipse.text.edits.TextEdit;
import java.util.List;
@@ -53,7 +54,13 @@ import java.util.List;
*/
public class ConvertMethodToGetterRefactoring extends Refactoring {
+ private static void addReplaceEdit(TextChange change, String name, SourceRange range, String text) {
+ TextEdit edit = new ReplaceEdit(range.getOffset(), range.getLength(), text);
+ TextChangeCompatibility.addTextEdit(change, name, edit);
+ }
+
private final DartFunction function;
+
private final CompilationUnit methodUnit;
private final TextChangeManager changeManager = new TextChangeManager(true);
@@ -102,10 +109,18 @@ public class ConvertMethodToGetterRefactoring extends Refactoring {
// convert method declaration(s) to getter
for (DartFunction function : declarations) {
TextChange change = changeManager.get(methodUnit);
- TextChangeCompatibility.addTextEdit(
+ addReplaceEdit(
+ change,
+ RefactoringCoreMessages.ConvertMethodToGetterRefactoring_make_getter_declaration,
+ SourceRangeFactory.forStartLength(function.getNameRange(), 0),
+ "get ");
+ addReplaceEdit(
change,
RefactoringCoreMessages.ConvertMethodToGetterRefactoring_make_getter_declaration,
- new ReplaceEdit(function.getNameRange().getOffset(), 0, "get "));
+ SourceRangeFactory.forEndEnd(
+ function.getNameRange(),
+ function.getParametersCloseParen()),
+ "");
pm.worked(1);
}
// convert all references
@@ -124,10 +139,11 @@ public class ConvertMethodToGetterRefactoring extends Refactoring {
SourceRange range = SourceRangeFactory.forStartEnd(
SourceRangeUtils.getEnd(reference.getSourceRange()),
invocation);
- TextChangeCompatibility.addTextEdit(
+ addReplaceEdit(
refChange,
RefactoringCoreMessages.ConvertMethodToGetterRefactoring_replace_invocation,
- new ReplaceEdit(range.getOffset(), range.getLength(), ""));
+ range,
+ "");
}
}
pm.worked(1);

Powered by Google App Engine
This is Rietveld 408576698