editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java - Issue 10916211: Issue 4752. When convert to getter, remove also ()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java

Issue 10916211: Issue 4752. When convert to getter, remove also () (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use setter in *Info Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/AST.java ('k') | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/CompilationUnitImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java

index 2f2113d86eb9c063807775ebb63fb96aa22dc2ba..d827bd1f780e9a50feaa45684f9aa7729bab6ee6 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java

@@ -26,15 +26,18 @@ public class FunctionCompleter extends DartFunction implements CompletionNode {

static final long serialVersionUID = 1L;

public static FunctionCompleter from(DartFunction p) {

- return CompletionUtil.init(

- new FunctionCompleter(p.getParameters(), p.getBody(), p.getReturnTypeNode()),

- p);

+ return CompletionUtil.init(new FunctionCompleter(

+ p.getParameters(),

+ p.getParametersCloseParen(),

+ p.getBody(),

+ p.getReturnTypeNode()), p);

}

private Stack<Mark> stack;

- public FunctionCompleter(List<DartParameter> params, DartBlock body, DartTypeNode returnTypeNode) {

- super(params, body, returnTypeNode);

+ public FunctionCompleter(List<DartParameter> params, int parametersCloseParen, DartBlock body,

+ DartTypeNode returnTypeNode) {

+ super(params, parametersCloseParen, body, returnTypeNode);

}

@Override