Issue 10916204: Remove FileEnumerator::IsLink

Issue 10916204: Remove FileEnumerator::IsLink (Closed)

Created:
8 years, 3 months ago by tzik

Modified:
8 years, 3 months ago

Reviewers:
Joao da Silva, satorux1, jar (doing other things)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove FileEnumerator::IsLink BUG=133270 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156229

Patch Set 2 : replace IsLink in chromeos code #

Total comments: 2

Patch Set 3 : fix indentation #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -13 lines)			Patch
M	base/file_util.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/file_util_posix.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/file_util_win.cc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/policy/app_pack_updater.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/drive_internals_ui.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

tzik

FileEnumerator::IsLink is broken and is not used. Can I remove it from FileEnumerator?

8 years, 3 months ago (2012-09-10 09:28:49 UTC) #1

jar (doing other things)

LGTM (be wary that distant users may appear... but we'll handle that if they appear).

8 years, 3 months ago (2012-09-10 16:59:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10916204/1

8 years, 3 months ago (2012-09-11 02:06:07 UTC) #3

commit-bot: I haz the power

Try job failure for 10916204-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 3 months ago (2012-09-11 02:34:03 UTC) #4

tzik

There are some users in Chrome OS. Joao, Satoru: I'd like to remove broken FileEnumerator::IsLink. ...

8 years, 3 months ago (2012-09-11 07:07:31 UTC) #5

Joao da Silva

policy/ lgtm https://chromiumcodereview.appspot.com/10916204/diff/1004/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc File chrome/browser/ui/webui/chromeos/drive_internals_ui.cc (right): https://chromiumcodereview.appspot.com/10916204/diff/1004/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc#newcode66 chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:66: file_util::IsLink(FileEnumerator::GetFilename(find_info)); nit: indentation

8 years, 3 months ago (2012-09-11 08:09:56 UTC) #6

tzik

Thanks, Joao! http://codereview.chromium.org/10916204/diff/1004/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc File chrome/browser/ui/webui/chromeos/drive_internals_ui.cc (right): http://codereview.chromium.org/10916204/diff/1004/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc#newcode66 chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:66: file_util::IsLink(FileEnumerator::GetFilename(find_info)); On 2012/09/11 08:09:56, Joao da Silva ...

8 years, 3 months ago (2012-09-11 12:40:42 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10916204/10

8 years, 3 months ago (2012-09-12 02:07:16 UTC) #9

Change committed as 156229

Expand Messages | Collapse Messages