Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2085)

Unified Diff: chrome/browser/resources/about_version.js

Issue 10916182: Refactor the about:version code out of about_ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: rebase + lei nit Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/about_version.html ('k') | chrome/browser/ui/webui/about_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/about_version.js
===================================================================
--- chrome/browser/resources/about_version.js (revision 158638)
+++ chrome/browser/resources/about_version.js (working copy)
@@ -8,20 +8,41 @@
* section if there are none to display.
* @param {!Array.<string>} variationsList The list of variations.
*/
-function returnVariationsList(variationsList) {
+function returnVariationInfo(variationsList) {
$('variations-section').hidden = !variationsList.length;
$('variations-list').appendChild(
parseHtmlSubset(variationsList.join('<br>'), ['BR']));
}
+/**
+ * Callback from the backend with the executable and profile paths to display.
+ * @param {string} execPath The executable path to display.
+ * @param {string} profilePath The profile path to display.
+ */
+function returnFilePaths(execPath, profilePath) {
+ $('executable_path').textContent = execPath;
+ $('profile_path').textContent = profilePath;
+}
+
+/**
+ * Callback from the backend with the Flash version to display.
+ * @param {string} flashVersion The Flash version to display.
+ */
+function returnFlashVersion(flashVersion) {
+ $('flash_version').textContent = flashVersion;
+}
+
+/**
+ * Callback from the backend with the OS version to display.
+ * @param {string} osVersion The OS version to display.
+ */
+function returnOsVersion(osVersion) {
+ $('os_version').textContent = osVersion;
+}
+
/* All the work we do onload. */
function onLoadWork() {
- // This is the javascript code that processes the template:
- var input = new JsEvalContext(templateData);
- var output = $('t');
- jstProcess(input, output);
-
- chrome.send('requestVariationsList');
+ chrome.send('requestVersionInfo');
}
document.addEventListener('DOMContentLoaded', onLoadWork);
« no previous file with comments | « chrome/browser/resources/about_version.html ('k') | chrome/browser/ui/webui/about_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698