chrome/browser/ui/views/location_bar/page_action_image_view.cc - Issue 10916180: Context menus on view elements should be positioned above the finger when

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view.cc

Issue 10916180: Context menus on view elements should be positioned above the finger when (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_frame_aura.cc ('k') | chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/page_action_image_view.cc

diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view.cc b/chrome/browser/ui/views/location_bar/page_action_image_view.cc

index f7b611ccf989ef0ab8f36c52ec969684147cfd7a..f44eb239f0240f26580de450d65ad0725fe8b8f0 100644

--- a/chrome/browser/ui/views/location_bar/page_action_image_view.cc

+++ b/chrome/browser/ui/views/location_bar/page_action_image_view.cc

@@ -213,7 +213,8 @@ void PageActionImageView::ShowContextMenuForView(View* source,

gfx::Point screen_loc;

views::View::ConvertPointToScreen(this, &screen_loc);

if (menu_runner_->RunMenuAt(GetWidget(), NULL, gfx::Rect(screen_loc, size()),

- views::MenuItemView::TOPLEFT, views::MenuRunner::HAS_MNEMONICS) ==

+ views::MenuItemView::TOPLEFT, views::MenuRunner::HAS_MNEMONICS |

+ views::MenuRunner::CONTEXT_MENU) ==

views::MenuRunner::MENU_DELETED)

return;

}