Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: lib/dom/scripts/systemhtml.py

Issue 10916177: Revert "Partially migrate from old getter syntax to new one." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/dom/scripts/systemnative.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemhtml.py
diff --git a/lib/dom/scripts/systemhtml.py b/lib/dom/scripts/systemhtml.py
index 1dc44c9396e3f1b734d2f38aca34a58f0c61cac0..2abfed2d85d1edecf4a0c69e84a2ab30b616046f 100644
--- a/lib/dom/scripts/systemhtml.py
+++ b/lib/dom/scripts/systemhtml.py
@@ -716,11 +716,11 @@ class HtmlDartInterfaceGenerator(BaseGenerator):
event_attrs = DomToHtmlEvents(self._html_interface_name, event_attrs)
for event_name in event_attrs:
if event_name in _html_event_names:
- events_members.Emit('\n EventListenerList get $NAME;\n',
+ events_members.Emit('\n EventListenerList get $NAME();\n',
NAME=_html_event_names[event_name])
implementation_events_members.Emit(
"\n"
- " EventListenerList get $NAME => this['$DOM_NAME'];\n",
+ " EventListenerList get $NAME() => this['$DOM_NAME'];\n",
NAME=_html_event_names[event_name],
DOM_NAME=event_name)
else:
@@ -732,11 +732,11 @@ class HtmlDartInterfaceGenerator(BaseGenerator):
'\n * @domName EventTarget.addEventListener, '
'EventTarget.removeEventListener, EventTarget.dispatchEvent'
'\n */'
- '\n $TYPE get on;\n',
+ '\n $TYPE get on();\n',
TYPE=events_interface)
self._implementation_members_emitter.Emit(
- '\n $TYPE get on =>\n new $TYPE(this);\n',
+ '\n $TYPE get on() =>\n new $TYPE(this);\n',
TYPE=events_class)
@@ -856,7 +856,7 @@ class HtmlDart2JSClassGenerator(Dart2JSInterfaceGenerator):
def AddIndexer(self, element_type):
"""Adds all the methods required to complete implementation of List."""
# We would like to simply inherit the implementation of everything except
- # length, [], and maybe []=. It is possible to extend from a base
+ # get length(), [], and maybe []=. It is possible to extend from a base
# array implementation class only when there is no other implementation
# inheritance. There might be no implementation inheritance other than
# DOMBaseWrapper for many classes, but there might be some where the
@@ -965,7 +965,7 @@ class HtmlDart2JSClassGenerator(Dart2JSInterfaceGenerator):
return self._AddConvertingGetter(attr, html_name, conversion)
return_type = self._NarrowOutputType(attr.type.id)
self._members_emitter.Emit(
- '\n $TYPE get $HTML_NAME native "return this.$NAME;";\n',
+ '\n $TYPE get $HTML_NAME() native "return this.$NAME;";\n',
HTML_NAME=html_name,
NAME=attr.id,
TYPE=return_type)
@@ -983,8 +983,8 @@ class HtmlDart2JSClassGenerator(Dart2JSInterfaceGenerator):
def _AddConvertingGetter(self, attr, html_name, conversion):
self._members_emitter.Emit(
- '\n $RETURN_TYPE get $HTML_NAME => $CONVERT(this._$(HTML_NAME));'
- '\n $NATIVE_TYPE get _$HTML_NAME native "return this.$NAME;";'
+ '\n $RETURN_TYPE get $HTML_NAME() => $CONVERT(this._$(HTML_NAME));'
+ '\n $NATIVE_TYPE get _$HTML_NAME() native "return this.$NAME;";'
'\n',
CONVERT=conversion.function_name,
HTML_NAME=html_name,
« no previous file with comments | « no previous file | lib/dom/scripts/systemnative.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698