Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4017)

Unified Diff: chrome/browser/file_select_helper.cc

Issue 10916160: Upstreaming SelectFileDialog for Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sky's nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/file_select_helper.cc
diff --git a/chrome/browser/file_select_helper.cc b/chrome/browser/file_select_helper.cc
index 7438a5063b83e835bc24273c2a59edca060fbd38..b6ab78b558c942ca72d3b3c26067757750c1ef44 100644
--- a/chrome/browser/file_select_helper.cc
+++ b/chrome/browser/file_select_helper.cc
@@ -407,6 +407,14 @@ void FileSelectHelper::RunFileChooserOnUIThread(
gfx::NativeWindow owning_window =
platform_util::GetTopLevel(render_view_host_->GetView()->GetNativeView());
+#if defined(OS_ANDROID)
+ // Android needs the original MIME types and an additional capture value.
+ std::vector<string16> accept_types(params.accept_types);
+ // We append the capture value to the end of the accept_types vector. This
+ // allows to pass MIME types and the capture value to the SelectFile method.
+ accept_types.push_back(params.capture);
+#endif
+
select_file_dialog_->SelectFile(
dialog_type_,
params.title,
@@ -416,7 +424,7 @@ void FileSelectHelper::RunFileChooserOnUIThread(
FILE_PATH_LITERAL(""),
owning_window,
#if defined(OS_ANDROID)
- const_cast<content::FileChooserParams*>(&params));
+ &accept_types);
#else
NULL);
#endif

Powered by Google App Engine
This is Rietveld 408576698