Upstreaming SelectFileDialog for Android

ui/gfx/android/window_android.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_GFX_ANDROID_WINDOW_ANDROID_H_
+#define UI_GFX_ANDROID_WINDOW_ANDROID_H_
+
+#include <jni.h>
+#include "base/android/scoped_java_ref.h"
+
+namespace ui {
+
+class WindowAndroid{

[sky, 2012/09/13 16:24:04]

WindowAndroid{ -> WindowAndroid {

[aurimas (slooooooooow), 2012/09/14 00:06:59]

Done.

+ public:
+  WindowAndroid(JNIEnv* env, jobject obj);
+  virtual ~WindowAndroid();

[sky, 2012/09/13 16:24:04]

Why virtual?

[aurimas (slooooooooow), 2012/09/14 00:06:59]

Done.

+  void Destroy(JNIEnv* env, jobject obj);

[sky, 2012/09/13 16:24:04]

newline between 16/17

[aurimas (slooooooooow), 2012/09/14 00:06:59]

Done.

+
+  base::android::ScopedJavaLocalRef<jobject> GetJavaObject();
+
+  static bool RegisterWindowAndroid(JNIEnv* env);
+
+ private:
+  struct JavaObject;
+  JavaObject* java_object_;

[sky, 2012/09/13 16:24:04]

Why don't you declare JavaObject by value?

[aurimas (slooooooooow), 2012/09/14 00:06:59]

Done.

+};

[sky, 2012/09/13 16:24:04]

DISALLOW_..

[aurimas (slooooooooow), 2012/09/14 00:06:59]

Done.

+
+}  // namespace ui
+
+#endif  // UI_GFX_ANDROID_WINDOW_ANDROID_H_