ui/gfx/android/window_android.h - Issue 10916160: Upstreaming SelectFileDialog for Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/android/window_android.h

Issue 10916160: Upstreaming SelectFileDialog for Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Elliot's nits Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GFX_ANDROID_WINDOW_ANDROID_H_

	6 #define UI_GFX_ANDROID_WINDOW_ANDROID_H_

	7

	8 #include <jni.h>

	9 #include "base/android/scoped_java_ref.h"

	10

	11 class WindowAndroid{

	12 public:

	13 WindowAndroid(JNIEnv* env, jobject obj);

	14 virtual ~WindowAndroid();

	15 void Destroy(JNIEnv* env, jobject obj);

	16

	17 base::android::ScopedJavaLocalRef<jobject> GetJavaObject();

	18

	19 private:

	20 struct JavaObject;

	21 JavaObject* java_object_;
	Yaron 2012/09/12 19:14:45 I think this should be a JavaObjectWeakGlobalRef I think this should be a JavaObjectWeakGlobalRef aurimas (slooooooooow) 2012/09/13 15:37:15 Is there an example somewhere? I followed content_ Show quoted text On 2012/09/12 19:14:45, Yaron wrote: > I think this should be a JavaObjectWeakGlobalRef Is there an example somewhere? I followed content_view_core as example for this.
	22 };

	23

	24 bool RegisterWindowAndroid(JNIEnv* env);
	Yaron 2012/09/12 19:14:45 Nit: make static member of above Nit: make static member of above aurimas (slooooooooow) 2012/09/13 15:37:15 Done. Show quoted text On 2012/09/12 19:14:45, Yaron wrote: > Nit: make static member of above Done.
	25

	26 #endif // UI_GFX_ANDROID_WINDOW_ANDROID_H_

OLD	NEW