AppCache and StoragePartition'ing

content/browser/storage_partition_impl.h

Index: content/browser/storage_partition_impl.h
===================================================================
--- content/browser/storage_partition_impl.h	(revision 154786)
+++ content/browser/storage_partition_impl.h	(working copy)
@@ -15,10 +15,10 @@
 
 namespace content {
 
-class StoragePartitionImpl : public StoragePartition {
+class StoragePartitionImpl
+    : public StoragePartition,
+      public base::RefCountedThreadSafe<StoragePartitionImpl> {
  public:
-  virtual ~StoragePartitionImpl();
-
   // TODO(ajwong): Break the direct dependency on |context|. We only
   // need 3 pieces of info from it.
   static StoragePartitionImpl* Create(BrowserContext* context,
@@ -26,13 +26,17 @@
 
   // StoragePartition interface.
   virtual quota::QuotaManager* GetQuotaManager() OVERRIDE;
-  virtual ChromeAppCacheService* GetAppCacheService() OVERRIDE;
+  virtual appcache::AppCacheService* GetAppCacheService() OVERRIDE;

[awong, 2012/09/06 22:29:27]

Why'd we remove the covariant return type here?

   virtual fileapi::FileSystemContext* GetFileSystemContext() OVERRIDE;
   virtual webkit_database::DatabaseTracker* GetDatabaseTracker() OVERRIDE;
   virtual DOMStorageContextImpl* GetDOMStorageContext() OVERRIDE;
   virtual IndexedDBContextImpl* GetIndexedDBContext() OVERRIDE;
 
  private:
+  friend class base::RefCountedThreadSafe<StoragePartitionImpl>;
+
+  virtual ~StoragePartitionImpl();
+
   StoragePartitionImpl(const FilePath& partition_path,
                        quota::QuotaManager* quota_manager,
                        ChromeAppCacheService* appcache_service,