AppCache and StoragePartition'ing

content/browser/worker_host/worker_process_host.cc

Index: content/browser/worker_host/worker_process_host.cc
===================================================================
--- content/browser/worker_host/worker_process_host.cc	(revision 156155)
+++ content/browser/worker_host/worker_process_host.cc	(working copy)
@@ -251,11 +251,21 @@
 }
 
 void WorkerProcessHost::CreateMessageFilters(int render_process_id) {
+  // TODO(michaeln): Put ChromeBlobStorageContext in StorageParition too.
+  ChromeBlobStorageContext* blob_storage_context =
+      content::GetChromeBlobStorageContextForResourceContext(
+          resource_context_);
+
+  // TODO(michaeln): This is not correct, shared workers will not be using the
+  // isolated/partitioned request context, they'll be using the cookies and
+  // cache associated with normal web browsing.

[michaeln, 2012/09/13 00:21:20]

The wrong RequestContext here is a blocker i think.

[awong, 2012/09/13 00:45:50]

Ick. It is a blocker to 144549, but not m23 luckily. Erik triaged out workers
from m23.

Can we cite 144549 in this TODO?

   net::URLRequestContext* request_context =
       resource_context_->GetRequestContext();
 
   ResourceMessageFilter* resource_message_filter = new ResourceMessageFilter(
       process_->GetData().id, content::PROCESS_TYPE_WORKER, resource_context_,
+      partition_.appcache_service(),
+      blob_storage_context,
       new URLRequestContextSelector(request_context));
   process_->GetHost()->AddFilter(resource_message_filter);
 
@@ -265,15 +275,13 @@
                  base::Unretained(WorkerServiceImpl::GetInstance())));
   process_->GetHost()->AddFilter(worker_message_filter_);
   process_->GetHost()->AddFilter(new AppCacheDispatcherHost(
-      static_cast<ChromeAppCacheService*>(
-          ResourceContext::GetAppCacheService(resource_context_)),
+      partition_.appcache_service(),
       process_->GetData().id));
   process_->GetHost()->AddFilter(new FileAPIMessageFilter(
       process_->GetData().id,
       request_context,
       partition_.filesystem_context(),
-      content::GetChromeBlobStorageContextForResourceContext(
-          resource_context_)));
+      blob_storage_context));
   process_->GetHost()->AddFilter(new FileUtilitiesMessageFilter(
       process_->GetData().id));
   process_->GetHost()->AddFilter(new MimeRegistryMessageFilter());