LayoutTests/fast/events/dom-character-data-modified-textarea-crash.html - Issue 10916125: Merge 125162

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/dom-character-data-modified-textarea-crash.html

Issue 10916125: Merge 125162 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1229/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/events/dom-character-data-modified-textarea-crash.html

===================================================================

--- LayoutTests/fast/events/dom-character-data-modified-textarea-crash.html (revision 127640)

+++ LayoutTests/fast/events/dom-character-data-modified-textarea-crash.html (working copy)

@@ -5,17 +5,28 @@

// This test uses a weired textarea to reproduce the issue. The condition of a crash is very sensitive to HTML.

// If we add a new-line at EOF or add other tags in <body> part, the crash will be unlikely to happen.

// For example, if we move this comment to the actual HTML or try to load 'js-test-pre.js', the crash won't happen.

-// Mutation events should not be dispatched on this case. This bug is being tracked by webkit bug https://bugs.webkit.org/show_bug.cgi?id=87372

-if (window.testRunner)

+//

+// * Mutation events should not be dispatched on this case. This bug is being tracked by webkit bug https://bugs.webkit.org/show_bug.cgi?id=87372

+// * ... And Mutation events are no longer fired. See https://bugs.webkit.org/show_bug.cgi?id=93427.

+// We would keep this test just for preventing regression.

+if (window.testRunner) {

testRunner.dumpAsText();

+ testRunner.waitUntilDone();

-document.addEventListener("DOMCharacterDataModified", function() {

+function attackAndFinish() {

document.designMode = "on";

document.execCommand("SelectAll");

document.execCommand("Delete");

document.body.offsetLeft;

document.body.innerHTML = 'Test passes if a DOMCharacterModified event on the textarea does not crash.';

-});

+ if (window.testRunner)

+ testRunner.notifyDone();

+document.addEventListener("DOMCharacterDataModified", attackAndFinish);

+window.setTimeout(attackAndFinish, 10);

</script>

</head>

-<textarea> <

+<textarea> <