Issue 10916095: Fix leaks in aura_unittests

Issue 10916095: Fix leaks in aura_unittests (Closed)

Created:
8 years, 3 months ago by oshima

Modified:
8 years, 3 months ago

Reviewers:
sadrul, sky

CC:
chromium-reviews, sadrul, pam+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix leaks in aura_unittests Suppress leaks that are in X and header to fix. BUG=144990, 146464, 146465 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154910

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -88 lines)			Patch
M	tools/heapcheck/suppressions.txt	View	1	2 chunks	+39 lines, -0 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1	2 chunks	+22 lines, -0 lines	0 comments	Download
M	ui/aura/event_filter_unittest.cc	View	1	7 chunks	+54 lines, -53 lines	0 comments	Download
M	ui/aura/gestures/gesture_recognizer_unittest.cc	View	1	3 chunks	+13 lines, -7 lines	0 comments	Download
M	ui/aura/root_window_unittest.cc	View	1	3 chunks	+12 lines, -11 lines	0 comments	Download
M	ui/aura/shared/compound_event_filter_unittest.cc	View	1	3 chunks	+0 lines, -12 lines	0 comments	Download
M	ui/aura/shared/input_method_event_filter_unittest.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/aura/test/test_window_delegate.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/aura/test/test_window_delegate.cc	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
M	ui/aura/window_unittest.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/base/gestures/gesture_recognizer_impl.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/base/touch/touch_factory.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

sadrul

LGTM I thought there was a bot to test these in the main console/waterfall. Is ...

8 years, 3 months ago (2012-09-05 02:56:54 UTC) #2

oshima

Yeah, it looks like aura/ash unittests has been excluded from memory bots by accident at ...

8 years, 3 months ago (2012-09-05 03:10:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10916095/5001

8 years, 3 months ago (2012-09-05 04:39:08 UTC) #5

Change committed as 154910