Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 10916080: yasm: merge fixes from upstream and remove warning suppression on win (Closed)

Created:
8 years, 3 months ago by scottmg
Modified:
8 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

yasm: merge fixes from upstream and remove warning suppression on win https://github.com/yasm/yasm/pull/64 was merged, so we can remove VS warning suppressions now. TBR=thakis@chromium.org BUG=126483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154708

Patch Set 1 #

Patch Set 2 : +deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/yasm/yasm.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
8 years, 3 months ago (2012-09-03 16:30:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10916080/1003
8 years, 3 months ago (2012-09-03 16:30:55 UTC) #2
Nico
lgtm if the win warning fixes didn't cause new warnings elsewhere (the bots will catch ...
8 years, 3 months ago (2012-09-03 16:40:39 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-03 18:44:44 UTC) #4
Change committed as 154708

Powered by Google App Engine
This is Rietveld 408576698