Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 10916076: Optimize dictionary enum generation. (Closed)

Created:
8 years, 3 months ago by Toon Verwaest
Modified:
8 years, 3 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Optimize dictionary enum generation. Committed: https://code.google.com/p/v8/source/detail?r=12426

Patch Set 1 #

Patch Set 2 : Do not convert keys to symbols while adding slow properties. #

Patch Set 3 : Adding comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -14 lines) Patch
M src/handles.cc View 1 2 1 chunk +30 lines, -4 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 2 chunks +35 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL.
8 years, 3 months ago (2012-09-03 08:39:31 UTC) #1
ulan
8 years, 3 months ago (2012-09-03 09:19:00 UTC) #2
LGTM, thanks for adding the comments!

Powered by Google App Engine
This is Rietveld 408576698