Add TCP and UDP proxies to NaCl IPC IRT build.

Add TCP, UDP, and HostResolver proxies to NaCl IPC IRT build.
BUG=116317
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154816

[dmichael (off chromium), 2012-08-31 16:48:40]

lgtm

http://codereview.chromium.org/10916040/diff/5004/ppapi/ppapi_shared.gypi
File ppapi/ppapi_shared.gypi (left):

http://codereview.chromium.org/10916040/diff/5004/ppapi/ppapi_shared.gypi#old...
ppapi/ppapi_shared.gypi:301: 'thunk/ppb_x509_certificate_private_thunk.cc',
I think these can safely move to the section below. I don't think we need them
for the nacl_broker on Windows.

http://codereview.chromium.org/10916040/diff/5004/ppapi/shared_impl/private/p...
File ppapi/shared_impl/private/ppb_host_resolver_shared.cc (right):

http://codereview.chromium.org/10916040/diff/5004/ppapi/shared_impl/private/p...
ppapi/shared_impl/private/ppb_host_resolver_shared.cc:22: NetAddressList*
CreateNetAddressListFromAddressList(
Maybe it would be good to ifdef this out from the header, as well? Should make
the error easier to figure out if we ever try to use it in untrusted code.

[bbudge, 2012-08-31 19:34:59]

Done done.

http://codereview.chromium.org/10916040/diff/5004/ppapi/ppapi_shared.gypi
File ppapi/ppapi_shared.gypi (left):

http://codereview.chromium.org/10916040/diff/5004/ppapi/ppapi_shared.gypi#old...
ppapi/ppapi_shared.gypi:301: 'thunk/ppb_x509_certificate_private_thunk.cc',
On 2012/08/31 16:48:40, dmichael wrote:
> I think these can safely move to the section below. I don't think we need them
> for the nacl_broker on Windows.

Done.

http://codereview.chromium.org/10916040/diff/5004/ppapi/shared_impl/private/p...
File ppapi/shared_impl/private/ppb_host_resolver_shared.cc (right):

http://codereview.chromium.org/10916040/diff/5004/ppapi/shared_impl/private/p...
ppapi/shared_impl/private/ppb_host_resolver_shared.cc:22: NetAddressList*
CreateNetAddressListFromAddressList(
On 2012/08/31 16:48:40, dmichael wrote:
> Maybe it would be good to ifdef this out from the header, as well? Should make
> the error easier to figure out if we ever try to use it in untrusted code.

Done.

[commit-bot: I haz the power, 2012-08-31 19:35:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/10916040/9004

[commit-bot: I haz the power, 2012-08-31 19:53:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/10916040/7002

[bbudge, 2012-08-31 20:32:27]

http://codereview.chromium.org/10916040/diff/5004/ppapi/ppapi_shared.gypi
File ppapi/ppapi_shared.gypi (left):

http://codereview.chromium.org/10916040/diff/5004/ppapi/ppapi_shared.gypi#old...
ppapi/ppapi_shared.gypi:301: 'thunk/ppb_x509_certificate_private_thunk.cc',
On 2012/08/31 19:34:59, bbudge1 wrote:
> On 2012/08/31 16:48:40, dmichael wrote:
> > I think these can safely move to the section below. I don't think we need
them
> > for the nacl_broker on Windows.
> 
> Done.

It looks like PPBHostResolver is needed somehow. On Win64 the build fails.

[dmichael (off chromium), 2012-08-31 20:40:12]

http://codereview.chromium.org/10916040/diff/5004/ppapi/ppapi_shared.gypi
File ppapi/ppapi_shared.gypi (left):

http://codereview.chromium.org/10916040/diff/5004/ppapi/ppapi_shared.gypi#old...
ppapi/ppapi_shared.gypi:301: 'thunk/ppb_x509_certificate_private_thunk.cc',
On 2012/08/31 20:32:27, bbudge1 wrote:
> On 2012/08/31 19:34:59, bbudge1 wrote:
> > On 2012/08/31 16:48:40, dmichael wrote:
> > > I think these can safely move to the section below. I don't think we need
> them
> > > for the nacl_broker on Windows.
> > 
> > Done.
> 
> It looks like PPBHostResolver is needed somehow. On Win64 the build fails.
I see... Must be for ppapi::HostPortPair in ppb_host_resolver_shared.h. You can
either ifdef around it in ppapi/shared_impl/private/ppb_host_resolver_shared.h
and only include that file, or just leave it in-tact (probably along with the
thunk file).

[commit-bot: I haz the power, 2012-08-31 22:01:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/10916040/7026

[commit-bot: I haz the power, 2012-08-31 22:21:04]

Try job failure for 10916040-7026 (retry) on win for step "runhooks" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[bbudge, 2012-09-01 00:55:52]

Add TCP, UDP, and HostResolver proxies to NaCl IPC IRT build.
BUG=116317
TEST=none

[bbudge, 2012-09-01 00:56:57]

I was having trouble with the Win64 build and Rietveld. Uploaded one more patch
and trying the CQ.

[commit-bot: I haz the power, 2012-09-01 00:57:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/10916040/4009

[commit-bot: I haz the power, 2012-09-01 02:11:42]

Try job failure for 10916040-4009 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-09-04 19:13:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/10916040/10005

[commit-bot: I haz the power, 2012-09-04 21:30:14]

Change committed as 154816