Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 10916021: Fix android_finder.py (Closed)

Created:
8 years, 3 months ago by jackpal
Modified:
8 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix ahe's feedback. + Define a util.Error class and use it instead of a raw Exception + Periods at the end of sentences in comments and error messages. + Destructuring assignment for working with tupples. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11667

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use startswith #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M runtime/tools/android_finder.py View 1 14 chunks +25 lines, -23 lines 0 comments Download
M runtime/tools/utils.py View 6 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jackpal
This is my response to Peter's review of android_finder.py (I can't figure out how to ...
8 years, 3 months ago (2012-08-30 18:38:10 UTC) #1
ahe
LGTM! You shouldn't modify the original CL. That's done now. Cheers, Peter http://codereview.chromium.org/10916021/diff/1/runtime/tools/android_finder.py File runtime/tools/android_finder.py ...
8 years, 3 months ago (2012-08-30 20:11:07 UTC) #2
jackpal
8 years, 3 months ago (2012-08-30 23:07:24 UTC) #3
http://codereview.chromium.org/10916021/diff/1/runtime/tools/android_finder.py
File runtime/tools/android_finder.py (right):

http://codereview.chromium.org/10916021/diff/1/runtime/tools/android_finder.p...
runtime/tools/android_finder.py:98: and
package_description.find(key_description_prefix) == 0):
On 2012/08/30 20:11:07, ahe wrote:
> startswith?

Done.

Powered by Google App Engine
This is Rietveld 408576698