Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10916019: Move MediaGalleries.getMediaFileSystems out of experimental. (Closed)

Created:
8 years, 3 months ago by vandebo (ex-Chrome)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move MediaGalleries.getMediaFileSystems out of experimental. BUG=110823, 116025, 145566 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154366

Patch Set 1 #

Patch Set 2 : Update docs #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -288 lines) Patch
M chrome/browser/extensions/api/media_galleries/media_galleries_api.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +5 lines, -14 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental_media_galleries.idl View 1 chunk +0 lines, -27 lines 0 comments Download
A + chrome/common/extensions/api/media_galleries.idl View 2 chunks +1 line, -23 lines 0 comments Download
M chrome/common/extensions/docs/server2/README View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/intros/experimental_mediaGalleries.html View 1 1 chunk +0 lines, -49 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/mediaGalleries.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/apps/experimental_mediaGalleries.html View 1 1 chunk +1 line, -1 line 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/mediaGalleries.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 5 chunks +8 lines, -5 lines 0 comments Download
A + chrome/renderer/extensions/media_galleries_custom_bindings.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + chrome/renderer/extensions/media_galleries_custom_bindings.cc View 3 chunks +6 lines, -6 lines 0 comments Download
D chrome/renderer/extensions/media_gallery_custom_bindings.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/renderer/extensions/media_gallery_custom_bindings.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js View 2 chunks +1 line, -18 lines 0 comments Download
A + chrome/renderer/resources/extensions/media_galleries_custom_bindings.js View 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/no_access/manifest.json View 1 chunk +2 lines, -2 lines 2 comments Download
M chrome/test/data/extensions/api_test/media_galleries/no_access/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/no_galleries/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/no_galleries/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/read_access/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/read_access/test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
vandebo (ex-Chrome)
PTAL asargent: for extension stuff thestig: for everything else
8 years, 3 months ago (2012-08-30 18:00:39 UTC) #1
asargent_no_longer_on_chrome
LGTM
8 years, 3 months ago (2012-08-30 22:49:16 UTC) #2
Lei Zhang
lgtm
8 years, 3 months ago (2012-08-30 23:03:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10916019/2001
8 years, 3 months ago (2012-08-30 23:05:18 UTC) #4
commit-bot: I haz the power
Try job failure for 10916019-2001 (retry) on mac_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-08-31 00:37:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10916019/2001
8 years, 3 months ago (2012-08-31 00:52:10 UTC) #6
commit-bot: I haz the power
Change committed as 154366
8 years, 3 months ago (2012-08-31 03:28:18 UTC) #7
Mihai Parparita -not on Chrome
https://chromiumcodereview.appspot.com/10916019/diff/2001/chrome/test/data/extensions/api_test/media_galleries/no_access/manifest.json File chrome/test/data/extensions/api_test/media_galleries/no_access/manifest.json (right): https://chromiumcodereview.appspot.com/10916019/diff/2001/chrome/test/data/extensions/api_test/media_galleries/no_access/manifest.json#newcode11 chrome/test/data/extensions/api_test/media_galleries/no_access/manifest.json:11: "permissions": ["mediaGalleries", "mediaGalleriesAllGalleries"] There was discussion during the API ...
8 years, 3 months ago (2012-08-31 04:17:46 UTC) #8
vandebo (ex-Chrome)
8 years, 3 months ago (2012-08-31 04:22:02 UTC) #9 
https://chromiumcodereview.appspot.com/10916019/diff/2001/chrome/test/data/ex...
File
chrome/test/data/extensions/api_test/media_galleries/no_access/manifest.json
(right):

https://chromiumcodereview.appspot.com/10916019/diff/2001/chrome/test/data/ex...
chrome/test/data/extensions/api_test/media_galleries/no_access/manifest.json:11:
"permissions": ["mediaGalleries", "mediaGalleriesAllGalleries"]
On 2012/08/31 04:17:46, Mihai Parparita wrote:
> There was discussion during the API review of switching to the new-style
> parametrized permission for this (e.g. {"mediaGalleries": ["read",
> "allGalleries"]}. See http://crrev.com/151956 which introduced it and made the
> socket API use it.
> 
> Is there a bug filed about this?

Yes, http://crbug.com/145567

Powered by Google App Engine
This is Rietveld 408576698