Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 10916016: Switch the TCP reads on Windows to use non-blocking/non-async I/O. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_client_socket_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
===================================================================
--- net/url_request/url_request_http_job.cc (revision 163292)
+++ net/url_request/url_request_http_job.cc (working copy)
@@ -1288,6 +1288,15 @@
UMA_HISTOGRAM_MEDIUM_TIMES("Net.HttpTimeToFirstByte", to_start);
+ static const bool use_overlapped_read_histogram =
+ base::FieldTrialList::TrialExists("OverlappedReadImpact");
+ if (use_overlapped_read_histogram) {
+ UMA_HISTOGRAM_MEDIUM_TIMES(
+ base::FieldTrial::MakeName("Net.HttpTimeToFirstByte",
+ "OverlappedReadImpact"),
+ to_start);
+ }
+
static const bool use_warm_socket_impact_histogram =
base::FieldTrialList::TrialExists("WarmSocketImpact");
if (use_warm_socket_impact_histogram) {
@@ -1481,6 +1490,41 @@
}
}
+ static const bool use_overlapped_read_histogram =
+ base::FieldTrialList::TrialExists("OverlappedReadImpact");
+ if (use_overlapped_read_histogram) {
+ UMA_HISTOGRAM_TIMES(
+ base::FieldTrial::MakeName("Net.HttpJob.TotalTime",
+ "OverlappedReadImpact"),
+ total_time);
+
+ if (reason == FINISHED) {
+ UMA_HISTOGRAM_TIMES(
+ base::FieldTrial::MakeName("Net.HttpJob.TotalTimeSuccess",
+ "OverlappedReadImpact"),
+ total_time);
+ } else {
+ UMA_HISTOGRAM_TIMES(
+ base::FieldTrial::MakeName("Net.HttpJob.TotalTimeCancel",
+ "OverlappedReadImpact"),
+ total_time);
+ }
+
+ if (response_info_) {
+ if (response_info_->was_cached) {
+ UMA_HISTOGRAM_TIMES(
+ base::FieldTrial::MakeName("Net.HttpJob.TotalTimeCached",
+ "OverlappedReadImpact"),
+ total_time);
+ } else {
+ UMA_HISTOGRAM_TIMES(
+ base::FieldTrial::MakeName("Net.HttpJob.TotalTimeNotCached",
+ "OverlappedReadImpact"),
+ total_time);
+ }
+ }
+ }
+
start_time_ = base::TimeTicks();
}
« no previous file with comments | « net/socket/tcp_client_socket_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698