Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: net/socket/tcp_client_socket_win.h

Issue 10916016: Switch the TCP reads on Windows to use non-blocking/non-async I/O. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/page_load_histograms.cc ('k') | net/socket/tcp_client_socket_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_client_socket_win.h
===================================================================
--- net/socket/tcp_client_socket_win.h (revision 163292)
+++ net/socket/tcp_client_socket_win.h (working copy)
@@ -72,6 +72,10 @@
virtual bool SetKeepAlive(bool enable, int delay);
virtual bool SetNoDelay(bool no_delay);
+ // Perform reads in non-blocking mode instead of overlapped mode.
+ // Used for experiments.
+ static void DisableOverlappedReads();
+
private:
// State machine for connecting the socket.
enum ConnectState {
@@ -99,11 +103,13 @@
// Called after Connect() has completed with |net_error|.
void LogConnectCompletion(int net_error);
+ int DoRead(IOBuffer* buf, int buf_len, const CompletionCallback& callback);
void DoReadCallback(int rv);
void DoWriteCallback(int rv);
void DidCompleteConnect();
void DidCompleteRead();
void DidCompleteWrite();
+ void DidSignalRead();
SOCKET socket_;
« no previous file with comments | « chrome/renderer/page_load_histograms.cc ('k') | net/socket/tcp_client_socket_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698