Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: net/socket/tcp_client_socket_win.h

Issue 10916016: Switch the TCP reads on Windows to use non-blocking/non-async I/O. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/tcp_client_socket_win.h
===================================================================
--- net/socket/tcp_client_socket_win.h (revision 161340)
+++ net/socket/tcp_client_socket_win.h (working copy)
@@ -72,6 +72,9 @@
virtual bool SetKeepAlive(bool enable, int delay);
virtual bool SetNoDelay(bool no_delay);
+ // Experiment entry point for non-blocking reads.
wtc 2012/10/18 23:17:10 Nit: please be more direct, something like: // P
pmeenan 2012/10/19 20:49:41 Done.
+ static void DisableOverlappedReads();
+
private:
// State machine for connecting the socket.
enum ConnectState {
@@ -104,6 +107,7 @@
void DidCompleteConnect();
void DidCompleteRead();
void DidCompleteWrite();
+ void DidSignalRead();
SOCKET socket_;

Powered by Google App Engine
This is Rietveld 408576698