Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 10916013: NOT FOR COMMIT - Example for michaelbai (Closed)

Created:
8 years, 3 months ago by Peter Beverloo
Modified:
8 years, 1 month ago
Reviewers:
michaelbai
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

NOT FOR COMMIT - Example for michaelbai BUG=

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M build/android/envsetup_functions.sh View 2 chunks +9 lines, -2 lines 4 comments Download

Messages

Total messages: 2 (0 generated)
michaelbai
https://chromiumcodereview.appspot.com/10916013/diff/1/build/android/envsetup_functions.sh File build/android/envsetup_functions.sh (right): https://chromiumcodereview.appspot.com/10916013/diff/1/build/android/envsetup_functions.sh#newcode98 build/android/envsetup_functions.sh:98: DEFINES+=" target_arch=arm" We also need to get ride of ...
8 years, 3 months ago (2012-08-30 16:38:40 UTC) #1
Peter Beverloo
8 years, 3 months ago (2012-08-30 20:17:24 UTC) #2
http://codereview.chromium.org/10916013/diff/1/build/android/envsetup_functio...
File build/android/envsetup_functions.sh (right):

http://codereview.chromium.org/10916013/diff/1/build/android/envsetup_functio...
build/android/envsetup_functions.sh:98: DEFINES+=" target_arch=arm"
On 2012/08/30 16:38:40, michaelbai wrote:
> We also need to get ride of the duplicated target_arch here. 

It's a nice-to-have, but by no means required. I don't think it's worth the
additional switch statement.

http://codereview.chromium.org/10916013/diff/1/build/android/envsetup_functio...
build/android/envsetup_functions.sh:126:
android-${target_arch}/gdbserver/gdbserver"
On 2012/08/30 16:38:40, michaelbai wrote:
> For x86 case,
> 
> We need set 
> target_arch=ia32
> android_gdbserver=${ANDROID_NDK_ROOT}/prebuilt/android-x86/gdbserver/gdbserver

line 118 should read "target_arch="x86"".

Powered by Google App Engine
This is Rietveld 408576698