Issue 10916013: NOT FOR COMMIT - Example for michaelbai

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10916013: NOT FOR COMMIT - Example for michaelbai (Closed)

Created:
8 years, 3 months ago by Peter Beverloo

Modified:
8 years, 1 month ago

Reviewers:
michaelbai

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NOT FOR COMMIT - Example for michaelbai BUG=

Patch Set 1 #

Total comments: 4

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	build/android/envsetup_functions.sh	View		2 chunks	+9 lines, -2 lines	4 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

michaelbai

https://chromiumcodereview.appspot.com/10916013/diff/1/build/android/envsetup_functions.sh File build/android/envsetup_functions.sh (right): https://chromiumcodereview.appspot.com/10916013/diff/1/build/android/envsetup_functions.sh#newcode98 build/android/envsetup_functions.sh:98: DEFINES+=" target_arch=arm" We also need to get ride of ...

8 years, 3 months ago (2012-08-30 16:38:40 UTC) #1

Peter Beverloo

8 years, 3 months ago (2012-08-30 20:17:24 UTC) #2

http://codereview.chromium.org/10916013/diff/1/build/android/envsetup_functio...
File build/android/envsetup_functions.sh (right):

http://codereview.chromium.org/10916013/diff/1/build/android/envsetup_functio...
build/android/envsetup_functions.sh:98: DEFINES+=" target_arch=arm"
On 2012/08/30 16:38:40, michaelbai wrote:
> We also need to get ride of the duplicated target_arch here. 

It's a nice-to-have, but by no means required. I don't think it's worth the
additional switch statement.

http://codereview.chromium.org/10916013/diff/1/build/android/envsetup_functio...
build/android/envsetup_functions.sh:126:
android-${target_arch}/gdbserver/gdbserver"
On 2012/08/30 16:38:40, michaelbai wrote:
> For x86 case,
> 
> We need set 
> target_arch=ia32
> android_gdbserver=${ANDROID_NDK_ROOT}/prebuilt/android-x86/gdbserver/gdbserver

line 118 should read "target_arch="x86"".

Expand Messages | Collapse Messages