Relanding "views: Add a gyp file to build webview.". Try 2.

Relanding "views: Add a gyp file to build webview.". Try 2.

This reverts commit d2287c4694d749d9e0c4095d7b004beee7b27e86.

BUG=105557
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154621

[tfarina, 2012-08-31 16:00:49]

Hi Ben, could you review this to me?

The errors that patch set 6 should fix are:

   Creating library ..\..\..\..\build\Debug\\lib\webview.lib and object
..\..\..\..\build\Debug\\lib\webview.exp
webview.obj : error LNK2019: unresolved external symbol "private: static bool
views::FocusManager::shortcut_handling_suspended_"
(?shortcut_handling_suspended_@FocusManager@views@@0_NA) referenced in function
"public: static void __cdecl
views::FocusManager::set_shortcut_handling_suspended(bool)"
(?set_shortcut_handling_suspended@FocusManager@views@@SAX_N@Z)
webview.obj : error LNK2019: unresolved external symbol "public: static class
views::ViewsDelegate * views::ViewsDelegate::views_delegate"
(?views_delegate@ViewsDelegate@views@@2PAV12@A) referenced in function "private:
class content::WebContents * __thiscall views::WebView::CreateWebContents(class
content::BrowserContext *,class content::SiteInstance *)"
(?CreateWebContents@WebView@views@@AAEPAVWebContents@content@@PAVBrowserContext@4@PAVSiteInstance@4@@Z)
..\..\..\..\build\Debug\\webview.dll : fatal error LNK1120: 2 unresolved
externals

Let me know wyt.

Thanks.

[tfarina, 2012-08-31 17:12:43]

On 2012/08/31 16:00:49, tfarina wrote:
> Hi Ben, could you review this to me?
> 
> The errors that patch set 6 should fix are:
> 
>    Creating library ..\..\..\..\build\Debug\\lib\webview.lib and object
> ..\..\..\..\build\Debug\\lib\webview.exp
> webview.obj : error LNK2019: unresolved external symbol "private: static bool
> views::FocusManager::shortcut_handling_suspended_"
> (?shortcut_handling_suspended_@FocusManager@views@@0_NA) referenced in
function
> "public: static void __cdecl
> views::FocusManager::set_shortcut_handling_suspended(bool)"
> (?set_shortcut_handling_suspended@FocusManager@views@@SAX_N@Z)
> webview.obj : error LNK2019: unresolved external symbol "public: static class
> views::ViewsDelegate * views::ViewsDelegate::views_delegate"
> (?views_delegate@ViewsDelegate@views@@2PAV12@A) referenced in function
"private:
> class content::WebContents * __thiscall
views::WebView::CreateWebContents(class
> content::BrowserContext *,class content::SiteInstance *)"
>
(?CreateWebContents@WebView@views@@AAEPAVWebContents@content@@PAVBrowserContext@4@PAVSiteInstance@4@@Z)
> ..\..\..\..\build\Debug\\webview.dll : fatal error LNK1120: 2 unresolved
> externals
> 
Looks like not fixed yet in patch set 6 :(

Do you know a way to fix those link issues?

[tfarina, 2012-09-01 18:47:27]

Issues fixed!

Landing...

[Ben Goodger (Google), 2012-09-04 15:26:49]

lgtm