Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 10915307: URLFetcher uses a TaskRunner instead of a message loop. (Closed)

Created:
8 years, 3 months ago by droger
Modified:
8 years, 3 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, stuartmorgan, cgrigoruta_google.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

URLFetcher uses a TaskRunner instead of a message loop. Note that with this change, the URLFetcher can still be used with a MessageLoop, since MessageLoop is a task runner. BUG=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157545

Patch Set 1 #

Patch Set 2 : Changes to url_fetcher.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -47 lines) Patch
M net/url_request/test_url_fetcher_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/test_url_fetcher_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_fetcher.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M net/url_request/url_fetcher_core.h View 6 chunks +15 lines, -12 lines 0 comments Download
M net/url_request/url_fetcher_core.cc View 8 chunks +29 lines, -21 lines 0 comments Download
M net/url_request/url_fetcher_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_fetcher_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
droger
8 years, 3 months ago (2012-09-17 12:50:55 UTC) #1
wtc
Patch set 2 LGTM.
8 years, 3 months ago (2012-09-17 22:45:10 UTC) #2
wtc
Nit: the CL's description says: This allow the URLFetcher to be used in conjunction with ...
8 years, 3 months ago (2012-09-17 22:47:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/10915307/2001
8 years, 3 months ago (2012-09-19 09:27:50 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 13:48:07 UTC) #5
Change committed as 157545

Powered by Google App Engine
This is Rietveld 408576698