Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10915268: Made chrome_main_delegate match the base class's definition. (Closed)

Created:
8 years, 3 months ago by michaelbai
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Made chrome_main_delegate match the base class's definition. BUG=143931 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156761 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156853

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : Fix error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/chrome_main_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
michaelbai
8 years, 3 months ago (2012-09-13 20:25:32 UTC) #1
michaelbai
8 years, 3 months ago (2012-09-13 22:33:56 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
8 years, 3 months ago (2012-09-13 23:58:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10915268/1
8 years, 3 months ago (2012-09-13 23:58:46 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) sync_integration_tests
8 years, 3 months ago (2012-09-14 04:06:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10915268/3002
8 years, 3 months ago (2012-09-14 04:34:54 UTC) #6
commit-bot: I haz the power
Change committed as 156761
8 years, 3 months ago (2012-09-14 07:20:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10915268/5007
8 years, 3 months ago (2012-09-14 16:53:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10915268/5007
8 years, 3 months ago (2012-09-14 17:43:58 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-09-14 18:54:18 UTC) #10 
Change committed as 156853

Powered by Google App Engine
This is Rietveld 408576698