Reduce space usage of simple transitions and descriptors holders.

src/transitions.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 17 matching lines @@
 #include "v8.h"
 
 #include "objects.h"
 #include "transitions-inl.h"
 #include "utils.h"
 
 namespace v8 {
 namespace internal {
 
 
-MaybeObject* TransitionArray::Allocate(int number_of_transitions,
-                                       JSGlobalPropertyCell* descriptors_cell) {
+static MaybeObject* AllocateRaw(int length,
+                                JSGlobalPropertyCell* descriptors_cell) {
   Heap* heap = Isolate::Current()->heap();
 
   if (descriptors_cell == NULL) {
     MaybeObject* maybe_cell =
         heap->AllocateJSGlobalPropertyCell(heap->empty_descriptor_array());
     if (!maybe_cell->To(&descriptors_cell)) return maybe_cell;
   }
 
-  // Use FixedArray to not use DescriptorArray::cast on incomplete object.
+  // Use FixedArray to not use TransitionArray::cast on incomplete object.
+  FixedArray* array;
+  MaybeObject* maybe_array = heap->AllocateFixedArray(length);
+  if (!maybe_array->To(&array)) return maybe_array;
+
+  array->set(TransitionArray::kDescriptorsPointerIndex, descriptors_cell);
+  return array;
+}
+
+
+MaybeObject* TransitionArray::Allocate(int number_of_transitions,
+                                       JSGlobalPropertyCell* descriptors_cell) {
   FixedArray* array;
   MaybeObject* maybe_array =
-      heap->AllocateFixedArray(ToKeyIndex(number_of_transitions));
+      AllocateRaw(ToKeyIndex(number_of_transitions), descriptors_cell);
   if (!maybe_array->To(&array)) return maybe_array;
-
-  array->set(kDescriptorsPointerIndex, descriptors_cell);
   array->set(kElementsTransitionIndex, Smi::FromInt(0));
   array->set(kPrototypeTransitionsIndex, Smi::FromInt(0));
   return array;
 }
 
 
 void TransitionArray::NoIncrementalWriteBarrierCopyFrom(TransitionArray* origin,
                                                         int origin_transition,
                                                         int target_transition) {
   NoIncrementalWriteBarrierSet(target_transition,
                                origin->GetKey(origin_transition),
                                origin->GetTarget(origin_transition));
 }
 
 
 static bool InsertionPointFound(String* key1, String* key2) {
   return key1->Hash() > key2->Hash();
 }
 
 
-MaybeObject* TransitionArray::NewWith(
-    String* name,
-    Map* target,
-    JSGlobalPropertyCell* descriptors_pointer,
-    Object* back_pointer) {
+MaybeObject* TransitionArray::NewWith(SimpleTransitionFlag flag,
+                                      String* key,
+                                      Map* target,
+                                      JSGlobalPropertyCell* descriptors_pointer,
+                                      Object* back_pointer) {
   TransitionArray* result;
+  MaybeObject* maybe_result;
 
-  MaybeObject* maybe_array = TransitionArray::Allocate(1, descriptors_pointer);
-  if (!maybe_array->To(&result)) return maybe_array;
-
-  result->NoIncrementalWriteBarrierSet(0, name, target);
+  if (flag == SIMPLE_TRANSITION) {
+    maybe_result = AllocateRaw(kSimpleTransitionSize, descriptors_pointer);
+    if (!maybe_result->To(&result)) return maybe_result;
+    result->set(kSimpleTransitionTarget, target);
+  } else {
+    maybe_result = Allocate(1, descriptors_pointer);
+    if (!maybe_result->To(&result)) return maybe_result;
+    result->NoIncrementalWriteBarrierSet(0, key, target);
+  }
   result->set_back_pointer_storage(back_pointer);
   return result;
 }
 
+
+MaybeObject* TransitionArray::AllocateDescriptorsHolder(
+    JSGlobalPropertyCell* descriptors_pointer) {
+  return AllocateRaw(kDescriptorsHolderSize, descriptors_pointer);
+}
+
+
+MaybeObject* TransitionArray::ExtendToFullTransitionArray() {
+  ASSERT(!IsFullTransitionArray());
+  int nof = number_of_transitions();
+  TransitionArray* result;
+  MaybeObject* maybe_result = Allocate(nof, descriptors_pointer());
+  if (!maybe_result->To(&result)) return maybe_result;
+
+  if (nof == 1) {
+    result->NoIncrementalWriteBarrierCopyFrom(this, kSimpleTransitionIndex, 0);
+  }
+
+  result->set_back_pointer_storage(back_pointer_storage());
+  return result;
+}
+
 
 MaybeObject* TransitionArray::CopyInsert(String* name, Map* target) {
   TransitionArray* result;
 
   int number_of_transitions = this->number_of_transitions();
   int new_size = number_of_transitions;
 
   int insertion_index = this->Search(name);
   if (insertion_index == kNotFound) ++new_size;
 
@@ skipping 32 matching lines @@
     result->NoIncrementalWriteBarrierCopyFrom(
         this, insertion_index, insertion_index + 1);
   }
 
   result->set_back_pointer_storage(back_pointer_storage());
   return result;
 }
 
 
 } }  // namespace v8::internal