Fix for pixelated icons in extension install ui on 2x scale.

Fix for pixelated icons in extension install ui on 2x scale.

We should probably do something like https://chromiumcodereview.appspot.com/10917146/ (and add lazy representation loading for views),
but for M23 timeframe this will also do.

BUG=135268
TEST=manual

TBR=aa@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157000

[tbarzic, 2012-09-13 03:17:38]

In case there will be no time to review the other cl..

[Jeffrey Yasskin, 2012-09-14 19:34:01]

LGTM with nits.

http://codereview.chromium.org/10915251/diff/6005/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_prompt.cc (right):

http://codereview.chromium.org/10915251/diff/6005/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_prompt.cc:471: // Load the icon
whose pixel size is large enough to be displayed under
Please add TODOs to load the precisely correct sizes.

http://codereview.chromium.org/10915251/diff/6005/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_uninstall_dialog.cc (right):

http://codereview.chromium.org/10915251/diff/6005/chrome/browser/extensions/e...
chrome/browser/extensions/extension_uninstall_dialog.cc:43:
supported_scale_factors[supported_scale_factors.size() - 1];
This should be written as supported_scale_factors.back().

[tbarzic, 2012-09-14 22:34:31]

http://codereview.chromium.org/10915251/diff/6005/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_prompt.cc (right):

http://codereview.chromium.org/10915251/diff/6005/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_prompt.cc:471: // Load the icon
whose pixel size is large enough to be displayed under
On 2012/09/14 19:34:01, Jeffrey Yasskin wrote:
> Please add TODOs to load the precisely correct sizes.

Done.

http://codereview.chromium.org/10915251/diff/6005/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_uninstall_dialog.cc (right):

http://codereview.chromium.org/10915251/diff/6005/chrome/browser/extensions/e...
chrome/browser/extensions/extension_uninstall_dialog.cc:43:
supported_scale_factors[supported_scale_factors.size() - 1];
On 2012/09/14 19:34:01, Jeffrey Yasskin wrote:
> This should be written as supported_scale_factors.back().

Done.

[commit-bot: I haz the power, 2012-09-15 02:25:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/10915251/10002

[commit-bot: I haz the power, 2012-09-15 03:22:10]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-15 04:32:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/10915251/10002

[commit-bot: I haz the power, 2012-09-15 10:50:55]

Change committed as 157000