Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: lib/html/templates/html/impl/impl_Element.darttemplate

Issue 10915245: Removing interfaces from dart:html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporating review feedback. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/html/templates/html/impl/impl_Element.darttemplate
diff --git a/lib/html/templates/html/impl/impl_Element.darttemplate b/lib/html/templates/html/impl/impl_Element.darttemplate
index 6371020d6e2017ad27a924af6c93bae9393c69fe..2b78504b5ab88b794ce226f09c96ba4e9267c262 100644
--- a/lib/html/templates/html/impl/impl_Element.darttemplate
+++ b/lib/html/templates/html/impl/impl_Element.darttemplate
@@ -836,7 +836,7 @@ class _ElementFactoryProvider {
};
/** @domName Document.createElement */
- factory Element.html(String html) {
+ static Element createElement_html(String html) {
// TODO(jacobr): this method can be made more robust and performant.
// 1) Cache the dummy parent elements required to use innerHTML rather than
// creating them every call.
@@ -875,8 +875,10 @@ class _ElementFactoryProvider {
$if DART2JS
// Optimization to improve performance until the dart2js compiler inlines this
// method.
- factory Element.tag(String tag) native "return document.createElement(tag)";
+ static Element createElement_tag(String tag)
+ native "return document.createElement(tag)";
$else
- factory Element.tag(String tag) => _document.$dom_createElement(tag);
+ static Element createElement_tag(String tag) =>
+ _document.$dom_createElement(tag);
$endif
}

Powered by Google App Engine
This is Rietveld 408576698