lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate - Issue 10915245: Removing interfaces from dart:html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate

Issue 10915245: Removing interfaces from dart:html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Incorporating review feedback. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/html/templates/html/dart2js/factoryprovider_FormData.darttemplate ('k') | lib/html/templates/html/dart2js/factoryprovider_MutationObserver.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate

diff --git a/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate b/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate

index 8ec7f2e3428a571936f41d5799e7c600bf2f91e1..e1f652b7bdee61e263b7cdb9a85ddc256620a304 100644

--- a/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate

+++ b/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate

@@ -3,13 +3,13 @@

// BSD-style license that can be found in the LICENSE file.

class $FACTORYPROVIDER {

- factory HttpRequest() native 'return new XMLHttpRequest();';

+ static HttpRequest createHttpRequest() native 'return new XMLHttpRequest();';

- factory HttpRequest.get(String url,

- onSuccess(HttpRequest request)) =>

+ static HttpRequest createHttpRequest_get(String url,

+ onSuccess(HttpRequest request)) =>

_HttpRequestUtils.get(url, onSuccess, false);

- factory HttpRequest.getWithCredentials(String url,

- onSuccess(HttpRequest request)) =>

+ static HttpRequest createHttpRequest_getWithCredentials(String url,

+ onSuccess(HttpRequest request)) =>

_HttpRequestUtils.get(url, onSuccess, true);

}