Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: lib/html/src/dart2js_FactoryProviders.dart

Issue 10915245: Removing interfaces from dart:html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporating review feedback. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class _AudioContextFactoryProvider { 5 class _AudioContextFactoryProvider {
6 6
7 factory AudioContext() native ''' 7 static AudioContext createAudioContext() native '''
8 var constructor = window.AudioContext || window.webkitAudioContext; 8 var constructor = window.AudioContext || window.webkitAudioContext;
9 return new constructor(); 9 return new constructor();
10 '''; 10 ''';
11 } 11 }
12 12
13 class _PointFactoryProvider { 13 class _PointFactoryProvider {
14 14 static Point createPoint(num x, num y) native
15 factory Point(num x, num y) native 'return new WebKitPoint(x, y);'; 15 'return new WebKitPoint(x, y);';
16 } 16 }
Lasse Reichstein Nielsen 2012/09/18 08:19:47 Can you make the original constructor do this dire
Anton Muhin 2012/09/18 08:20:54 Lasse, that is planned, but Peter prefers to do sm
17 17
18 class _WebSocketFactoryProvider { 18 class _WebSocketFactoryProvider {
19 19 static WebSocket createWebSocket(String url) native
20 factory WebSocket(String url) native '''return new WebSocket(url);'''; 20 '''return new WebSocket(url);''';
21 } 21 }
22 22
23 class _TextFactoryProvider { 23 class _TextFactoryProvider {
24 factory Text(String data) native "return document.createTextNode(data);"; 24 static Text createText(String data) native
25 "return document.createTextNode(data);";
25 } 26 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698