Issue 10915240: Fix the patch application sorting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10915240: Fix the patch application sorting. (Closed)

Created:
8 years, 3 months ago by M-A Ruel

Modified:
8 years, 3 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, alexeypa (please no reviews), Wez

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Fix the patch application sorting. It relied on a behavior that doesn't hold on python 2.7 anymore w.r.t. tuple comparison to non-tuple objects. Now be explicit about having source files to be first. R=rogerta@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156355

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	checkout.py	View		3 chunks	+3 lines, -0 lines	0 comments	Download
	M	patch.py	View		1 chunk	+7 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10915240/1

8 years, 3 months ago (2012-09-12 19:22:33 UTC) #3

Change committed as 156355