Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 10915227: Minimal number of if-def changes to support OS_IOS in content_main_runner.cc (Closed)

Created:
8 years, 3 months ago by leng
Modified:
8 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Minimal number of if-def changes to support OS_IOS in content_main_runner.cc Revert "Revert 155980 - Minimal number of if-def changes to support OS_IOS in content_main_runner.cc" This reverts commit d582fbc2e6a6490096e3b5b6fcafbb228f90fcfe. The original CL had moved the initialization of the AtExitManager to within a non-Windows block. This moves it back down to where it was originally, adding a !OS_IOS to the !OS_ANDROID define. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156520

Patch Set 1 #

Patch Set 2 : Moved AtExitManager out of non-windows block #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M content/app/content_main_runner.cc View 1 13 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
leng
Here's a version with a patch showing the diff between the original CL and the ...
8 years, 3 months ago (2012-09-12 11:41:37 UTC) #1
jam
lgtm
8 years, 3 months ago (2012-09-12 15:19:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10915227/8001
8 years, 3 months ago (2012-09-12 15:20:17 UTC) #3
commit-bot: I haz the power
Try job failure for 10915227-8001 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 3 months ago (2012-09-12 16:02:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10915227/3006
8 years, 3 months ago (2012-09-13 07:50:00 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 09:57:15 UTC) #6
Change committed as 156520

Powered by Google App Engine
This is Rietveld 408576698