Browser test for the push messaging feature

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 454 matching lines @@
 
 void ProfileSyncService::UnregisterInvalidationHandler(
     syncer::InvalidationHandler* handler) {
   invalidator_registrar_.UnregisterHandler(handler);
 }
 
 syncer::InvalidatorState ProfileSyncService::GetInvalidatorState() const {
   return invalidator_registrar_.GetInvalidatorState();
 }
 
+// Test method for system test to allow a test to send in an invalidation.

[akalin, 2012/09/17 23:20:14]

this comment doesn't say much, either.  I think you can just remove it.

+void ProfileSyncService::SendInvalidationForTest(
+    const invalidation::ObjectId& id,
+    const std::string& payload) {
+  // insert the object into the list of IDs to notify

[akalin, 2012/09/17 23:20:14]

this comment doesn't say much

+  syncer::ObjectIdSet notify_ids;
+  notify_ids.insert(id);
+
+  // Build an object state map, and use it to forward the call to

[akalin, 2012/09/17 23:20:14]

i don't know if this says muchmore, either

+  // registered clients such as PushMessagingHandler::OnIncomingNotification
+  // as if this came from the server.
+  const syncer::ObjectIdStateMap& id_state_map =
+      ObjectIdSetToStateMap(notify_ids, payload);
+  OnIncomingInvalidation(id_state_map, syncer::REMOTE_INVALIDATION);
+}
+
 void ProfileSyncService::Shutdown() {
   ShutdownImpl(false);
 }
 
 void ProfileSyncService::ShutdownImpl(bool sync_disabled) {
   // First, we spin down the backend and wait for it to stop syncing completely
   // before we Stop the data type manager.  This is to avoid a late sync cycle
   // applying changes to the sync db that wouldn't get applied via
   // ChangeProcessors, leading to back-from-the-dead bugs.
   base::Time shutdown_start_time = base::Time::Now();
@@ skipping 1325 matching lines @@
   // See http://stackoverflow.com/questions/6224121/is-new-this-myclass-undefined-behaviour-after-directly-calling-the-destru.
   ProfileSyncService* old_this = this;
   this->~ProfileSyncService();
   new(old_this) ProfileSyncService(
       new ProfileSyncComponentsFactoryImpl(profile,
                                            CommandLine::ForCurrentProcess()),
       profile,
       signin,
       behavior);
 }