[NaCl SDK] build_sdk uses gyp to build, not scons. *

[NaCl SDK] build_sdk uses gyp to build, not scons. *

* For x86-32, x86-64. Not pnacl.

BUG=none
TBR=viettrungluu@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158417

[binji, 2012-09-14 06:13:57]

This patch currently works on linux, but fails on windows (requires gyp roll to
fix), and fails on mac (requires nacl roll to fix).

I'll verify that all platforms work before committing.

[noelallen1, 2012-09-14 20:56:16]

lgtm

[binji, 2012-09-20 00:23:31]

+ncbray, see patchset 4 for changes I had to make to simple_test.

[binji, 2012-09-21 19:34:27]

+viettrungluu for ppapi OWNERS
+ncbray (as reviewer) for chrome/test/data/nacl OWNERS

[Nick Bray, 2012-09-21 22:29:12]

Owners LGTM, but please coordinate with me on CQ/merge issues.

[noelallen1, 2012-09-21 23:20:25]

Let's commit this and post the library to a bug for moving more of build_sdk out
of the script and into GYP.

http://codereview.chromium.org/10915213/diff/12003/chrome/test/data/nacl/nacl...
File chrome/test/data/nacl/nacl_browser_test.gypi (right):

http://codereview.chromium.org/10915213/diff/12003/chrome/test/data/nacl/nacl...
chrome/test/data/nacl/nacl_browser_test.gypi:135:
'--library-path=<(SHARED_INTERMEDIATE_DIR)/tc_glibc/lib64',
Are you using anything that's not in the SDK here?  If not, then we should find
a way to do with without additional library paths.  And why isn't newlib
affected?

http://codereview.chromium.org/10915213/diff/12003/ppapi/ppapi_untrusted.gyp
File ppapi/ppapi_untrusted.gyp (right):

http://codereview.chromium.org/10915213/diff/12003/ppapi/ppapi_untrusted.gyp#...
ppapi/ppapi_untrusted.gyp:147:
'--library-path=<(SHARED_INTERMEDIATE_DIR)/tc_glibc/lib64',
Should we be changing the output directory for the libraries this uses?  Same as
previous such comment.

[binji, 2012-09-24 17:59:56]

http://codereview.chromium.org/10915213/diff/12003/chrome/test/data/nacl/nacl...
File chrome/test/data/nacl/nacl_browser_test.gypi (right):

http://codereview.chromium.org/10915213/diff/12003/chrome/test/data/nacl/nacl...
chrome/test/data/nacl/nacl_browser_test.gypi:135:
'--library-path=<(SHARED_INTERMEDIATE_DIR)/tc_glibc/lib64',
On 2012/09/21 23:20:25, noelallen1 wrote:
> Are you using anything that's not in the SDK here?  If not, then we should
find
> a way to do with without additional library paths.  

Presently, all untrusted .a and .so files are built into this new directory.
They are only copied into the same directory as the untarred toolchain as an SDK
build step.

I suppose we could have a naclsdk target and have these tests depend on it.

> And why isn't newlib affected?

newlib doesn't need the library path, because it doesn't have shared libraries.

[commit-bot: I haz the power, 2012-09-24 19:58:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/10915213/12003

[commit-bot: I haz the power, 2012-09-24 22:14:35]

Change committed as 158417