Issue 10915200: Optimistically inline Math.sqrt as unboxed sqrtsd instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10915200: Optimistically inline Math.sqrt as unboxed sqrtsd instruction. (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Optimistically inline Math.sqrt as unboxed sqrtsd instruction. R=kmillikin@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12200

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -15 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	2 chunks	+15 lines, -3 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	runtime/vm/intermediate_language.h	View	6 chunks	+48 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

8 years, 3 months ago (2012-09-11 14:43:15 UTC) #4

lgtm

https://chromiumcodereview.appspot.com/10915200/diff/1/runtime/vm/il_printer.cc
File runtime/vm/il_printer.cc (right):

https://chromiumcodereview.appspot.com/10915200/diff/1/runtime/vm/il_printer....
runtime/vm/il_printer.cc:443: void
MathSqrtInstr::PrintOperandsTo(BufferFormatter* f) const {
Default implementation Definition::PrintOperandsTo should do this.

Expand Messages | Collapse Messages