Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 10915194: Add an ostream operator to Value (based on JSONWriter) so that assertions (Closed)

Created:
8 years, 3 months ago by not at google - send to devlin
Modified:
8 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, benwells
Visibility:
Public.

Description

Add an ostream operator to Value (based on JSONWriter) so that assertions involving Value::Equals are much easier to understand. For example, ListValue list; DictionaryValue dict; ASSERT_TRUE(Value::Equals(&list, &dict)) << list << "does not equal\n" << dict; will now print Value of: Value::Equals(&list, &dict) Actual: false Expected: true [ ] does not equal { } Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156226

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : remove base:: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M base/values.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/values.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
8 years, 3 months ago (2012-09-12 00:16:41 UTC) #1
willchan no longer on Chromium
lgtm https://chromiumcodereview.appspot.com/10915194/diff/2001/base/values.cc File base/values.cc (right): https://chromiumcodereview.appspot.com/10915194/diff/2001/base/values.cc#newcode1064 base/values.cc:1064: base::JSONWriter::WriteWithOptions(&value, is the base:: here necessary? We're in ...
8 years, 3 months ago (2012-09-12 01:20:13 UTC) #2
not at google - send to devlin
https://chromiumcodereview.appspot.com/10915194/diff/2001/base/values.cc File base/values.cc (right): https://chromiumcodereview.appspot.com/10915194/diff/2001/base/values.cc#newcode1064 base/values.cc:1064: base::JSONWriter::WriteWithOptions(&value, On 2012/09/12 01:20:13, willchan wrote: > is the ...
8 years, 3 months ago (2012-09-12 01:21:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10915194/5001
8 years, 3 months ago (2012-09-12 01:22:37 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-12 03:39:37 UTC) #5
Change committed as 156226

Powered by Google App Engine
This is Rietveld 408576698