Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: content/browser/download/download_browsertest.cc

Issue 10915180: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: @r168573 Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_browsertest.cc
diff --git a/content/browser/download/download_browsertest.cc b/content/browser/download/download_browsertest.cc
index 8c3bbbc4862e24a287e9ef9527f1f8995e1b0cd3..006b64025c24e1338203b60d5dc2d4da1bbe944c 100644
--- a/content/browser/download/download_browsertest.cc
+++ b/content/browser/download/download_browsertest.cc
@@ -236,10 +236,6 @@ void DownloadFileWithDelayFactory::WaitForSomeCallback() {
}
}
-bool WasPersisted(DownloadItem* item) {
- return item->IsPersisted();
-}
-
class CountingDownloadFile : public DownloadFileImpl {
public:
CountingDownloadFile(
@@ -472,10 +468,6 @@ IN_PROC_BROWSER_TEST_F(DownloadContentTest, DownloadCancelled) {
ASSERT_EQ(1u, downloads.size());
ASSERT_EQ(DownloadItem::IN_PROGRESS, downloads[0]->GetState());
- // Wait for it to be persisted.
- DownloadUpdatedObserver(
- downloads[0], base::Bind(&WasPersisted)).WaitForEvent();
-
// Cancel the download and wait for download system quiesce.
downloads[0]->Delete(DownloadItem::DELETE_DUE_TO_USER_DISCARD);
scoped_refptr<DownloadTestFlushObserver> flush_observer(
@@ -659,9 +651,6 @@ IN_PROC_BROWSER_TEST_F(DownloadContentTest, ShutdownInProgress) {
ASSERT_EQ(1u, items.size());
EXPECT_EQ(DownloadItem::IN_PROGRESS, items[0]->GetState());
- // Wait for it to be persisted.
- DownloadUpdatedObserver(items[0], base::Bind(&WasPersisted)).WaitForEvent();
-
// Shutdown the download manager and make sure we get the right
// notifications in the right order.
StrictMock<MockDownloadItemObserver> item_observer;

Powered by Google App Engine
This is Rietveld 408576698