Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: chrome/browser/download/chrome_download_manager_delegate_unittest.cc

Issue 10915180: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: @r168573 Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_path.h" 5 #include "base/file_path.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/files/scoped_temp_dir.h" 7 #include "base/files/scoped_temp_dir.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/observer_list.h" 9 #include "base/observer_list.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 EXPECT_CALL(*download_manager_, GetAllDownloads(_)).WillRepeatedly(Return()); 296 EXPECT_CALL(*download_manager_, GetAllDownloads(_)).WillRepeatedly(Return());
297 EXPECT_CALL(*download_manager_, AddObserver(_)).WillRepeatedly(Return()); 297 EXPECT_CALL(*download_manager_, AddObserver(_)).WillRepeatedly(Return());
298 EXPECT_CALL(*download_manager_, RemoveObserver(_)).WillRepeatedly(Return()); 298 EXPECT_CALL(*download_manager_, RemoveObserver(_)).WillRepeatedly(Return());
299 } 299 }
300 300
301 void ChromeDownloadManagerDelegateTest::SetUp() { 301 void ChromeDownloadManagerDelegateTest::SetUp() {
302 ChromeRenderViewHostTestHarness::SetUp(); 302 ChromeRenderViewHostTestHarness::SetUp();
303 303
304 CHECK(profile()); 304 CHECK(profile());
305 delegate_ = new TestChromeDownloadManagerDelegate(profile()); 305 delegate_ = new TestChromeDownloadManagerDelegate(profile());
306 EXPECT_CALL(*download_manager_.get(), GetAllDownloads(_))
307 .WillRepeatedly(Return());
308 EXPECT_CALL(*download_manager_.get(), AddObserver(_))
309 .WillRepeatedly(Return());
306 delegate_->SetDownloadManager(download_manager_.get()); 310 delegate_->SetDownloadManager(download_manager_.get());
307 pref_service_ = profile()->GetTestingPrefService(); 311 pref_service_ = profile()->GetTestingPrefService();
308 web_contents()->SetDelegate(&web_contents_delegate_); 312 web_contents()->SetDelegate(&web_contents_delegate_);
309 313
310 ASSERT_TRUE(test_download_dir_.CreateUniqueTempDir()); 314 ASSERT_TRUE(test_download_dir_.CreateUniqueTempDir());
311 SetDefaultDownloadPath(test_download_dir_.path()); 315 SetDefaultDownloadPath(test_download_dir_.path());
312 } 316 }
313 317
314 void ChromeDownloadManagerDelegateTest::TearDown() { 318 void ChromeDownloadManagerDelegateTest::TearDown() {
315 message_loop_.RunUntilIdle(); 319 message_loop_.RunUntilIdle();
(...skipping 592 matching lines...) Expand 10 before | Expand all | Expand 10 after
908 // Run the first test case again. Since the last download path was cleared, 912 // Run the first test case again. Since the last download path was cleared,
909 // this test case should behave identically to the first time it was run. 913 // this test case should behave identically to the first time it was run.
910 RunTestCases(kLastSavePathTestCases, 1); 914 RunTestCases(kLastSavePathTestCases, 1);
911 } 915 }
912 916
913 // TODO(asanka): Add more tests. 917 // TODO(asanka): Add more tests.
914 // * Default download path is not writable. 918 // * Default download path is not writable.
915 // * Download path doesn't exist. 919 // * Download path doesn't exist.
916 // * IsDangerousFile(). 920 // * IsDangerousFile().
917 // * Filename generation. 921 // * Filename generation.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698