ui/base/touch/touch_device_win.h - Issue 10915175: CSS Media Query now reports touch-support accurately for Windows (retry)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/touch/touch_device_win.h

Issue 10915175: CSS Media Query now reports touch-support accurately for Windows (retry) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Turfing out copyright headers. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #ifndef UI_BASE_TOUCH_TOUCH_DEVICE_H_

	2 #define UI_BASE_TOUCH_TOUCH_DEVICE_H_

	3

	4 #include "ui/base/ui_export.h"

	5

	6 namespace ui {

	7 namespace base {
	Rick Byers 2012/09/10 18:15:12 We don't normally use "ui::base", do we? The ambi We don't normally use "ui::base", do we? The ambiguity with ::base could be annoying if more files started to include this header (as you saw with the build error). I did a quick check elsewhere in ui/base/ and found only 'namespace ui', but maybe I'm missing some. girard 2012/09/10 19:03:03 The namespace is ambiguous, and this can be annoyi Show quoted text On 2012/09/10 18:15:12, Rick Byers wrote: > We don't normally use "ui::base", do we? The ambiguity with ::base could be > annoying if more files started to include this header (as you saw with the build > error). I did a quick check elsewhere in ui/base/ and found only 'namespace > ui', but maybe I'm missing some. The namespace is ambiguous, and this can be annoying. I would assume that removing the similar namespace would be troublesome to say the least. It's not a big deal to use a full path to specify the namespace. My bigger concern is that only chromeos complained about this... Apparently the different compilers or flags have different implementations of Koenig lookup.
	8

	9 // Returns true if a touch device is available.

	10 UI_EXPORT bool IsTouchDevicePresent();

	11

	12 } // namespace base

	13 } // namespace ui

	14

	15 #endif // UI_BASE_TOUCH_TOUCH_DEVICE_H_

OLD	NEW

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | ui/base/touch/touch_device_win.cc » ('j') | no next file with comments »