Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: third_party/harfbuzz-ng/src/hb-object-private.hh

Issue 10915172: harfbuzz-ng roll (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/harfbuzz-ng/src/hb-mutex-private.hh ('k') | third_party/harfbuzz-ng/src/hb-old.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/harfbuzz-ng/src/hb-object-private.hh
diff --git a/third_party/harfbuzz-ng/src/hb-object-private.hh b/third_party/harfbuzz-ng/src/hb-object-private.hh
index 96d1bd3a7cab327613a5659ae8b1f492e538bb3a..c48f24231d9c8fd1671c3f2d2170adc342c64413 100644
--- a/third_party/harfbuzz-ng/src/hb-object-private.hh
+++ b/third_party/harfbuzz-ng/src/hb-object-private.hh
@@ -103,7 +103,7 @@ struct hb_user_data_array_t
struct hb_object_header_t
{
hb_reference_count_t ref_count;
- hb_mutex_t lock;
+ hb_mutex_t mutex;
hb_user_data_array_t user_data;
#define HB_OBJECT_HEADER_STATIC {HB_REFERENCE_COUNT_INVALID, HB_MUTEX_INIT, HB_USER_DATA_ARRAY_INIT}
@@ -119,7 +119,7 @@ struct hb_object_header_t
inline void init (void) {
ref_count.init (1);
- lock.init ();
+ mutex.init ();
user_data.init ();
}
@@ -140,12 +140,20 @@ struct hb_object_header_t
return false;
ref_count.finish (); /* Do this before user_data */
- user_data.finish (lock);
- lock.finish ();
+ user_data.finish (mutex);
+ mutex.finish ();
return true;
}
+ inline void lock (void) {
+ mutex.lock ();
+ }
+
+ inline void unlock (void) {
+ mutex.unlock ();
+ }
+
inline bool set_user_data (hb_user_data_key_t *key,
void * data,
hb_destroy_func_t destroy_func,
@@ -153,19 +161,19 @@ struct hb_object_header_t
if (unlikely (!this || this->is_inert ()))
return false;
- return user_data.set (key, data, destroy_func, replace, lock);
+ return user_data.set (key, data, destroy_func, replace, mutex);
}
inline void *get_user_data (hb_user_data_key_t *key) {
if (unlikely (!this || this->is_inert ()))
return NULL;
- return user_data.get (key, lock);
+ return user_data.get (key, mutex);
}
inline void trace (const char *function) const {
if (unlikely (!this)) return;
- /* XXX We cannot use DEBUG_MSG_FUNC here since that one currecntly only
+ /* TODO We cannot use DEBUG_MSG_FUNC here since that one currently only
* prints the class name and throws away the template info. */
DEBUG_MSG (OBJECT, (void *) this,
"%s refcount=%d",
@@ -211,6 +219,18 @@ static inline bool hb_object_destroy (Type *obj)
return obj->header.destroy ();
}
template <typename Type>
+static inline void hb_object_lock (Type *obj)
+{
+ hb_object_trace (obj, HB_FUNC);
+ return obj->header.lock ();
+}
+template <typename Type>
+static inline void hb_object_unlock (Type *obj)
+{
+ hb_object_trace (obj, HB_FUNC);
+ return obj->header.unlock ();
+}
+template <typename Type>
static inline bool hb_object_set_user_data (Type *obj,
hb_user_data_key_t *key,
void * data,
« no previous file with comments | « third_party/harfbuzz-ng/src/hb-mutex-private.hh ('k') | third_party/harfbuzz-ng/src/hb-old.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698